All of the callers have context available:
https://codesearch.wmcloud.org/search/?q=createTextSlotDiffRenderer%5C%28&files=&excludeFiles=&repos=
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T11968 Reduce use of global and public variables | |||
| Open | None | T422741 Reduce uses of RequestContext::getMain in MediaWiki code | |||
| Open | None | T422745 Reduce use of RequestContext::getMain in MediaWiki core (outside test code) | |||
| Open | None | T423621 Do not use global context in ContentHandler::createTextSlotDiffRenderer |
Event Timeline
Comment Actions
ContentHandler::createTextSlotDiffRenderer() only needs a MessageLocalizer, not a full IContextSource, so maybe we should only require that. On the other hand, for symmetry with the other getSlotDiffRendererX methods, it would also make sense to require a full IContextSource.