Maniphest T423711

LexemeHistoryActionTest broken by extra HTML
Closed, ResolvedPublic
Actions

Description

Seen in three gate-and-submit builds (a fourth one failed due to T421827 instead) for this harmless change.

1) Wikibase\Lexeme\Tests\MediaWiki\Actions\LexemeHistoryActionTest::testFallsBackToParentIfNoLexemeId
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'(history-title: Page title)'
+'(history-title: <span lang="en" dir="ltr"><span class="mw-page-title-main">Page title</span></span>)'

/workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Actions/LexemeHistoryActionTest.php:46

Probably due to HistoryAction: Ensure correct language and direction of title (T36514) which was merged just now.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	LexemeHistoryActionTest: Update for core changes	mediawiki/extensions/WikibaseLexeme	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned Here: T36514: The language and the direction of the title in first heading should depend on page content language instead of user interface language
T421827: gerrit: Adapt timeouts to avoid 502 errors in CI jobs

Event Timeline

Lucas_Werkmeister_WMDE created this task.Fri, Apr 17, 3:12 PM

Change #1273846 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] LexemeHistoryActionTest: Update for core changes

https://gerrit.wikimedia.org/r/1273846

gerritbot added a project: Patch-For-Review.Fri, Apr 17, 3:16 PM

Lucas_Werkmeister_WMDE added a project: Wikidata-Omega (The Board).Fri, Apr 17, 3:17 PM

Lucas_Werkmeister_WMDE moved this task from new to the board to Ready for Peer Review on the Wikidata-Omega (The Board) board.

Change #1273846 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] LexemeHistoryActionTest: Update for core changes

https://gerrit.wikimedia.org/r/1273846

Should be fixed.

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Fri, Apr 17, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 17, 4:31 PM

Thanks! See also HistoryEntityActionTest: loosen test for history title (1273185) which is how I fixed this for wikibase.

TV: Both solutions work,
Thank you both.

mahmoud.abdelsattar.wmde closed this task as Resolved.Mon, Apr 20, 7:48 AM

mahmoud.abdelsattar.wmde claimed this task.

mahmoud.abdelsattar.wmde moved this task from Ready for Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.

mahmoud.abdelsattar.wmde edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).

karapayneWMDE moved this task from Newly completed tasks to 2026 Q2 on the Wikidata-Omega (Completed Tasks) board.Mon, May 4, 8:05 AM