Page MenuHomePhabricator

VisualEditor hCaptcha: Remove on load checkbox if CAPTCHA error is returned
Closed, ResolvedPublicBUG REPORT

Description

Summary

If an AbuseFilter consequence is fired to force show a captcha, the user is editing via VisualEditor, Bot detection and mitigation (WE4.2 hCaptcha editing trial) is in use, and the checkbox is not invisible then the user can see two checkboxes appear

Background

  • An AbuseFilter can force a captcha to show, which may be using a different sitekey (such as one to force a visual challenge)
    • When this happens with invisible mode off, the hCaptcha checkbox is shown twice on the page and it is not clear which one needs to be checked to continue with the edit

Screenshot

image.png (1×787 px, 152 KB)

Acceptance criteria

  • The old checkbox is destroyed or hidden to avoid multiple checkboxes

Event Timeline

Change #1275871 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] VisualEditor hCaptcha: Remove onload widget on captcha error

https://gerrit.wikimedia.org/r/1275871

Change #1275871 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] VisualEditor hCaptcha: Remove onload widget on captcha error

https://gerrit.wikimedia.org/r/1275871

Suggest regression testing using prod config. Only visible changes are when a wiki does not use invisible mode for the checkbox

Testing notes

I have only tested on testwiki or local wiki with a relatively production like config.

If someone wants to test this locally with the checkboxes, that's great, otherwise you can move this to done.