Hi @cmelo!

I am discussing this ticket with @JFernandez-WMF. It generally looks good (we made some tweaks to the language, but nothing major). However, we are wondering about the placement of the preference. The AC says it would be in a section for CampaignEvents in Preferences. From our understanding, this section does not yet exist, correct? We are wondering if it makes more sense to either rename the Invitation Lists section in Preferences to be "Event discovery" and include this preference under that section OR perhaps create a new section under Editing for post-edit actions, with the first one being this preference (since other teams are working on post-edit actions as well). What do you think?

Also, @bmartinezcalvo, @ppelberg, @KStoller-WMF, & @AAlhazwani-WMF: Are the Editing or Growth teams interested in creating a new section in preferences for a post-edit moment (so people can opt out of seeing some things after they publish edit)?

Also, @bmartinezcalvo, @ppelberg, @KStoller-WMF, & @AAlhazwani-WMF: Are the Editing or Growth teams interested in creating a new section in preferences for a post-edit moment (so people can opt out of seeing some things after they publish edit)?

Growth allows users to opt-out of our post-edit dialogs via a “Don’t show this again” check box.

I believe the opt-out isn’t actually saved as a Preference, but as a user property or ConditionalUserOption [citation needed / I might be wrong].

Either way, we should ensure we aren’t serving competing post-edit dialogs. So let me know if you need more information from Growth!

El T423741#11919038, @ifried escribió:

Also, @bmartinezcalvo, @ppelberg, @KStoller-WMF, & @AAlhazwani-WMF: Are the Editing or Growth teams interested in creating a new section in preferences for a post-edit moment (so people can opt out of seeing some things after they publish edit)?

Adding a new Preferences section for this feels more complex. Keeping it in the dialog itself (like Growth's dialog) is more contextual since the user can act on it right when it's relevant, without having to find it in preferences. Also, given that Growth already uses this solution, it makes sense to align on the same pattern.

Thank you so much for your feedback and for offering alternatives, @KStoller-WMF & @bmartinezcalvo!

We discussed this in our team meeting on May 14, and decided on the following:

• We want it to be a preference so that a) people can opt in/out rather than being stuck as opt out, and b) it is actually technically easier to implement this way because this would not be per-event but for all events (which would require us to create a new table to store this data).
• Since Growth and Editing do not have a need for a post-edit section in Preferences, we will alter the existing Invitation lists section in Preferences to be more broadly for Event discovery, which is where we'll place this preference
• @JFernandez-WMF can create a design example and then move it into Ready

I added the designs for preferences - @ifried, @cmelo do we also need designs for the hide message in the dialog?

In T423741#11920119, @KStoller-WMF wrote:

I believe the opt-out isn’t actually saved as a Preference, but as a user property or ConditionalUserOption [citation needed / I might be wrong].

From what I can see in the source, the opt-out is still saved as a user preference, Just, seemingly, not exposed on Special:Preferences. I do have thoughts on that, for example the fact, mentioned above, that it's not clear how you would opt back in. So, I agree with the idea of renaming the existing section of Special:Preferences and adding this one (although mind you, we could still use the preferences backend without exposing the checkbox there, which is unrelated to this not being per-event).

We discussed this in a team meeting, and @JFernandez-WMF will create a basic design to show the placement of the message in the post-edit dialog.

designs added, moving to ready for dev cc @ifried :)

El T423741#11983301, @JFernandez-WMF escribió:

designs added, moving to ready for dev cc @ifried :)

Just review the updated designs and commenting some feedback about the button's copy. As recommended in the Codex content guidelines, we should avoid language that implies visual skills to make the content accessible for everyone. So I recommend rephrasing the See event page button to View event page or Navigate to event page.

@bmartinezcalvo thank you <3! i don't think the designs are definitive yet (only the text about hiding the message is)-- so i'll change that!

In T423741#11985390, @bmartinezcalvo wrote:

El T423741#11983301, @JFernandez-WMF escribió:

designs added, moving to ready for dev cc @ifried :)

Just review the updated designs and commenting some feedback about the button's copy. As recommended in the Codex content guidelines, we should avoid language that implies visual skills to make the content accessible for everyone. So I recommend rephrasing the See event page button to View event page or Navigate to event page.

@bmartinezcalvo just noting that "View event page" is still a _visual_ verb and has the same a11y issue as "See event page".

@JFernandez-WMF i'm taking advantage of this note to also share a few spontaneous thoughts on copy:

1. "You're already part of something bigger!"
   • this feels a bit too informal and vague. also "bigger" is idiom-adjacent and might be non-trivial to translate. something like Your edit is part of an ongoing effort might also help shorteing the text below.
2. "The article you just edited is on the worklist for {Event}. Join the event to have your impact tracked and connect with other editors working on this topic."
   • i feel we're trying to pack possible too much in this sentence: explaining the situation, upselling joining events, and sharing benefits. also "connect with other editors working on this topic" are both long phrases with structural complexity - the passive construction in the first and the relative clause in the second will expand significantly in german, greek, or malayalam languages. something like This article is part of {Event}. Join to measure your impact and collaborate with editors on this topic. might work better.
3. "You can hide this message in the future by going to your user preferences."
   • this sentence is explaining how to use the UI rather than doing something the UI can't do. something like To stop seeing this, update your preferences. where "update your preferences" links to the user preferences page. or Hide this message in your preferences. where "your preferences" is the link.
4. "See/View event page" / "Cancel"
   • what about Join event so that we can make the main CTA more action oriented, alternative it could be Open event if we don't want to imply commitment.
   • Dismiss might be a better alternative instead of "Cancel" given that this is not a user initiated action. thou i'm also wondering if we need a Dismiss button given that we already have the X button.

El T423741#11987991, @AAlhazwani-WMF escribió:

@bmartinezcalvo just noting that "View event page" is still a _visual_ verb and has the same a11y issue as "See event page".

@AAlhazwani-WMF I know both are visual verbs, but to me "view" feels closer to "open" or "navigate to," whereas "see" feels more related to the act of visually perceiving (but ignore if it's not true since I'm not entirely sure about this distinction in English). In addition, i was proposing to use "View" since we already use it in other places like "View history".