Parsoid LanguageConverter sets top level `lang` and `dir` attributes to the base language not the variant
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Fri, Apr 17, 9:38 PM

Description

See
https://gan.wikipedia.org/wiki/%E6%80%A7%E4%BA%A4?useparsoid=1&variant=gan-hant
vs
https://gan.wikipedia.org/wiki/%E6%80%A7%E4%BA%A4?useparsoid=0&variant=gan-hant

The top level <div> for legacy is:

<div class="mw-content-ltr mw-parser-output" lang="gan-Hant" dir="ltr">

while for Parsoid it is:

<div class="mw-content-ltr mw-parser-output" lang="gan" dir="ltr" data-mw-parsoid-version="0.23.0.0-alpha27" data-mw-html-version="2.8.0">

This also affects every page with ku-arab, since they are not rendered rtl:
https://ku.wikipedia.org/wiki/Got%C3%BBb%C3%AAja%20bikarh%C3%AAner%3AGhybu?useparsoid=0&variant=ku-arab
vs
https://ku.wikipedia.org/wiki/Got%C3%BBb%C3%AAja%20bikarh%C3%AAner%3AGhybu?useparsoid=1&variant=ku-arab

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ParsoidLanguageConverter: update lang/dir on content wrapper div	mediawiki/core	wmf/1.46.0-wmf.24	+36 -2
	ParsoidLanguageConverter: update lang/dir on content wrapper div	mediawiki/core	master	+36 -2

Customize query in gerrit

Related Objects

Mentioned In: T422966: Parsoid tokenizer doesn't allow table or list markup inside language conversion brackets
T423662: CTT tasks week of 2026-04-17
T423763: phpunit PKSA-5jz8-6tcw-pbk4 breaks CI
T423192: Galleries on Parsoid don't support data attributes
T420102: Special:LintTemplateErrors shows parser functions without context
T423785: Parsoid Read Views to deploy ~2026-04-20 (Language Converter wikis)
Mentioned Here: T420102: Special:LintTemplateErrors shows parser functions without context
T422966: Parsoid tokenizer doesn't allow table or list markup inside language conversion brackets
T423192: Galleries on Parsoid don't support data attributes
T423662: CTT tasks week of 2026-04-17
T423763: phpunit PKSA-5jz8-6tcw-pbk4 breaks CI

Event Timeline

cscott created this task.Fri, Apr 17, 9:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Apr 17, 9:38 PM

cscott renamed this task from Parsoid LanguageConverter sets top level `lang` attribute to the base language not the variant to Parsoid LanguageConverter sets top level `lang` and `dir` attributes to the base language not the variant.Fri, Apr 17, 10:27 PM

cscott updated the task description. (Show Details)

Change #1274127 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParsoidLanguageConverter: update lang/dir on content wrapper div

https://gerrit.wikimedia.org/r/1274127

gerritbot added a project: Patch-For-Review.Fri, Apr 17, 10:46 PM

cscott moved this task from Backlog to Code Review on the Content-Transform-Team (Work In Progress) board.Fri, Apr 17, 11:33 PM

cscott mentioned this in T423785: Parsoid Read Views to deploy ~2026-04-20 (Language Converter wikis).Sat, Apr 18, 4:29 PM

Change #1274127 merged by jenkins-bot:

[mediawiki/core@master] ParsoidLanguageConverter: update lang/dir on content wrapper div

https://gerrit.wikimedia.org/r/1274127

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Mon, Apr 20, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mon, Apr 20, 11:32 PM

Change #1275561 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@wmf/1.46.0-wmf.24] ParsoidLanguageConverter: update lang/dir on content wrapper div

https://gerrit.wikimedia.org/r/1275561

gerritbot added a project: Patch-For-Review.Tue, Apr 21, 12:29 AM

Change #1275561 merged by jenkins-bot:

[mediawiki/core@wmf/1.46.0-wmf.24] ParsoidLanguageConverter: update lang/dir on content wrapper div

https://gerrit.wikimedia.org/r/1275561

Mentioned in SAL (#wikimedia-operations) [2026-04-21T14:09:44Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1275541|Bump wikimedia/parsoid to 0.23.0-a28 (T420102 T421680 T422879 T422966 T423192 T423763 T423662)]], [[gerrit:1275542|Bump wikimedia/parsoid to 0.23.0-a28 (T423662)]], [[gerrit:1275560|[tests] add ParsoidLanguageConverterTest]], [[gerrit:1275561|ParsoidLanguageConverter: update lang/dir on content wrapper div (T423747)]]

Mentioned in SAL (#wikimedia-operations) [2026-04-21T14:11:25Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1275541|Bump wikimedia/parsoid to 0.23.0-a28 (T420102 T421680 T422879 T422966 T423192 T423763 T423662)]], [[gerrit:1275542|Bump wikimedia/parsoid to 0.23.0-a28 (T423662)]], [[gerrit:1275560|[tests] add ParsoidLanguageConverterTest]], [[gerrit:1275561|ParsoidLanguageConverter: update lang/dir on content wrapper div (T423747)]] synced to the testservers (see https://wikit

Mentioned in SAL (#wikimedia-operations) [2026-04-21T14:22:46Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1275541|Bump wikimedia/parsoid to 0.23.0-a28 (T420102 T421680 T422879 T422966 T423192 T423763 T423662)]], [[gerrit:1275542|Bump wikimedia/parsoid to 0.23.0-a28 (T423662)]], [[gerrit:1275560|[tests] add ParsoidLanguageConverterTest]], [[gerrit:1275561|ParsoidLanguageConverter: update lang/dir on content wrapper div (T423747)]] (duration: 13m 02s)