Page MenuHomePhabricator
Create Task
Maniphest T423755

Deleted file revisions displaying improperly
Closed, DuplicatePublicBUG REPORT
Actions

Assigned To
None
Authored By
TechnoSquirrel69
Sat, Apr 18, 12:09 AM
Tags
Referenced Files
F76507485: image.png
Sat, Apr 18, 3:22 PM
F76507501: image.png
Sat, Apr 18, 3:22 PM
F76438197: image.png
Sat, Apr 18, 12:09 AM
F76438178: image.png
Sat, Apr 18, 12:09 AM
Subscribers
A_smart_kitten
Aklapper
KylieTastic
Novem_Linguae
TechnoSquirrel69
Zabe

Description

Steps to replicate the issue (include links if applicable):

  • Navigate to a file with a deleted revision. For example, this one.
  • Click on the link for that revision.

What happens?:

The link points to a non-existent page on upload.wikimedia.org, displaying an error.

What should have happened instead?:

Deleted revisions should not be linked and should display as struck out.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

image.png (59×433 px, 5 KB)

image.png (35×772 px, 5 KB)

Related Objects

Event Timeline

TechnoSquirrel69 created this task.Sat, Apr 18, 12:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Apr 18, 12:09 AM
TechnoSquirrel69 added a comment.Sat, Apr 18, 12:10 AM

This may or may not be related to T28741.

TechnoSquirrel69 added a project: Regression.Sat, Apr 18, 12:10 AM
Novem_Linguae added a parent task: T420483: 1.46.0-wmf.25 deployment blockers.EditedSat, Apr 18, 12:17 AM
Novem_Linguae subscribed.

I'm able to reproduce.

Major MediaWiki core regression = train blocker? Although it's already deployed so maybe that isn't the best way to solve this. Will help to get more eyes on it though.

Maintenance_bot added a project: Commons.Sat, Apr 18, 12:30 AM
KylieTastic subscribed.Sat, Apr 18, 3:11 PM

I believe this is related to T423065

Novem_Linguae added a comment.Sat, Apr 18, 3:22 PM

This is reproducible on testwiki: https://test.wikipedia.org/wiki/File:Test_file.png

Exact steps to reproduce

  • Upload a file
  • Upload a 2nd revision to the file
  • Revision delete the older revision, ticking just the "hide file content" check box

Appears to affect both newly revision deleted files and previously revision deleted files.

image.png (778×1 px, 70 KB)

image.png (757×2 px, 177 KB)

Novem_Linguae triaged this task as Unbreak Now! priority.Sat, Apr 18, 3:23 PM
Zabe subscribed.EditedSat, Apr 18, 5:12 PM
In T423755#11835364, @Novem_Linguae wrote:

I'm able to reproduce.

Major MediaWiki core regression = train blocker? Although it's already deployed so maybe that isn't the best way to solve this. Will help to get more eyes on it though.

Yeah this did not show up due to the train but rather due to https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1269086 (especially if it does not appear on commons)

A_smart_kitten subscribed.Sat, Apr 18, 5:14 PM
Zabe closed this task as a duplicate of T423065: Stuck-hidden file / Deleted file revisions displaying improperly.Sat, Apr 18, 5:21 PM
Zabe removed a parent task: T420483: 1.46.0-wmf.25 deployment blockers.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits