Page MenuHomePhabricator

Deleted file revisions displaying improperly
Closed, DuplicatePublicBUG REPORT

Assigned To
None
Authored By
TechnoSquirrel69
Sat, Apr 18, 12:09 AM
Referenced Files
F76507485: image.png
Sat, Apr 18, 3:22 PM
F76507501: image.png
Sat, Apr 18, 3:22 PM
F76438197: image.png
Sat, Apr 18, 12:09 AM
F76438178: image.png
Sat, Apr 18, 12:09 AM

Description

Steps to replicate the issue (include links if applicable):

  • Navigate to a file with a deleted revision. For example, this one.
  • Click on the link for that revision.

What happens?:

The link points to a non-existent page on upload.wikimedia.org, displaying an error.

What should have happened instead?:

Deleted revisions should not be linked and should display as struck out.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

image.png (59×433 px, 5 KB)

image.png (35×772 px, 5 KB)

Event Timeline

Novem_Linguae subscribed.

I'm able to reproduce.

Major MediaWiki core regression = train blocker? Although it's already deployed so maybe that isn't the best way to solve this. Will help to get more eyes on it though.

This is reproducible on testwiki: https://test.wikipedia.org/wiki/File:Test_file.png

Exact steps to reproduce

  • Upload a file
  • Upload a 2nd revision to the file
  • Revision delete the older revision, ticking just the "hide file content" check box

Appears to affect both newly revision deleted files and previously revision deleted files.

image.png (778×1 px, 70 KB)

image.png (757×2 px, 177 KB)

Novem_Linguae triaged this task as Unbreak Now! priority.Sat, Apr 18, 3:23 PM

I'm able to reproduce.

Major MediaWiki core regression = train blocker? Although it's already deployed so maybe that isn't the best way to solve this. Will help to get more eyes on it though.

Yeah this did not show up due to the train but rather due to https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1269086 (especially if it does not appear on commons)