AbuseFilter edit window cannot be resized horizontally
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Titore
	Sat, Apr 18, 1:38 AM

Description

Since T399673, the AbuseFilter edit window is not longer resizable horizontally. This was finally made possible with the old Ace editor in T294856.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping	mediawiki/extensions/AbuseFilter	wmf/1.46.0-wmf.24	+10 -3
	ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping	mediawiki/extensions/AbuseFilter	master	+9 -3

Customize query in gerrit

Related Objects

Mentioned In: T423773: AbuseFilter editor shifts off-screen when using long lines of code with line wrap disabled
Mentioned Here: T423773: AbuseFilter editor shifts off-screen when using long lines of code with line wrap disabled
T423759: CodeMirror's AbuseFilter edit window lacks the toolbar
T294856: Improvements to the editing interface
T399673: Add CodeMirror mode for AbuseFilter syntax

Event Timeline

Titore created this task.Sat, Apr 18, 1:38 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Apr 18, 1:38 AM

Titore renamed this task from AbuseFilter edit window cannot be resized to AbuseFilter edit window cannot be resized horizontally.Sat, Apr 18, 1:59 AM

Titore updated the task description. (Show Details)

Horizontal resizability was discouraged in r1247931, and it may also conflict with T423759 if we want to add a WikiEditor toolbar.

@MusikAnimal @Samwilson Any thoughts on this topic? Should we consider adding horizontal resizability to CodeMirror or only the CodeMirror-AbuseFilter integration?

Change #1275243 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/AbuseFilter@master] ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping

https://gerrit.wikimedia.org/r/1275243

gerritbot added a project: Patch-For-Review.Mon, Apr 20, 3:12 AM

I would think we should allow it to be resizable both horizontally and vertically everywhere, except wherever there's a conflicting layout, like ProofreadPage (where we want vertical-only).

Another approach is to put the burden on the caller, by having the extension set the CSS resize on the textarea itself, and then CodeMirror just copies that. To my knowledge it's only ProofreadPage where we'd want to do this.

MusikAnimal moved this task from Backlog to Bugs on the MediaWiki-extensions-CodeMirror board.Mon, Apr 20, 8:50 PM

Change #1275243 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping

https://gerrit.wikimedia.org/r/1275243

Change #1275760 had a related patch set uploaded (by MusikAnimal; author: Bhsd):

[mediawiki/extensions/AbuseFilter@wmf/1.46.0-wmf.24] ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping

https://gerrit.wikimedia.org/r/1275760

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Tue, Apr 21, 8:00 AM

Change #1275760 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@wmf/1.46.0-wmf.24] ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping

https://gerrit.wikimedia.org/r/1275760

Mentioned in SAL (#wikimedia-operations) [2026-04-21T08:10:52Z] <musikanimal@deploy1003> Started scap sync-world: Backport for [[gerrit:1275760|ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping (T423773 T423756)]]

Mentioned in SAL (#wikimedia-operations) [2026-04-21T08:12:34Z] <musikanimal@deploy1003> musikanimal: Backport for [[gerrit:1275760|ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping (T423773 T423756)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-04-21T08:17:54Z] <musikanimal@deploy1003> Finished scap sync-world: Backport for [[gerrit:1275760|ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping (T423773 T423756)]] (duration: 07m 01s)