Page MenuHomePhabricator
Create Task
Maniphest T423773

AbuseFilter editor shifts off-screen when using long lines of code with line wrap disabled
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Ensure line wrapping is enabled (should be the default in AbuseFilter since T399673)
  • Open a filter containing a long line of code, such as itwiki's filter 795 (or the original enwiki's filter 793)
  • Press Ctrl +Shift+,
  • Uncheck "Wrap lines"

What happens?:

The editor apparently disappears, leaving a blank page. It actually shifted far to the right side of the screen, as better noticeable when zooming out a few times (Ctrl + -)

What should have happened instead?:

Edit window should remain visible.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ext.abuseFilter.edit: rework CodeMirror integrationmediawiki/extensions/AbuseFiltermaster+34 -39
ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrappingmediawiki/extensions/AbuseFilterwmf/1.46.0-wmf.24+10 -3
ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrappingmediawiki/extensions/AbuseFiltermaster+9 -3
Customize query in gerrit

Related Objects

Event Timeline

Titore created this task.Sat, Apr 18, 9:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Apr 18, 9:53 AM
Titore updated the task description. (Show Details)Sat, Apr 18, 10:34 AM
Bhsd moved this task from Backlog to Bugs on the MediaWiki-extensions-CodeMirror board.Sat, Apr 18, 2:56 PM
Bhsd added subscribers: MusikAnimal, Bhsd.Sun, Apr 19, 4:06 PM

I think a temporary workaround is to lock the preference of line wrapping (and perhaps add a horizontal resizability so users can have a wider editor and less line wrapping if that is desired).

@MusikAnimal This looks like a severe bug that we may want to handle quickly.

gerritbot added a comment.Mon, Apr 20, 3:12 AM

Change #1275243 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/AbuseFilter@master] ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping

https://gerrit.wikimedia.org/r/1275243

gerritbot added a project: Patch-For-Review.Mon, Apr 20, 3:12 AM
MusikAnimal triaged this task as High priority.Mon, Apr 20, 7:16 PM

Possibly should be UBN.

gerritbot added a comment.Mon, Apr 20, 7:36 PM

Change #1275512 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/AbuseFilter@master] ext.abuseFilter.edit: rework CodeMirror integration

https://gerrit.wikimedia.org/r/1275512

gerritbot added a comment.Tue, Apr 21, 7:49 AM

Change #1275243 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping

https://gerrit.wikimedia.org/r/1275243

gerritbot added a comment.Tue, Apr 21, 7:49 AM

Change #1275760 had a related patch set uploaded (by MusikAnimal; author: Bhsd):

[mediawiki/extensions/AbuseFilter@wmf/1.46.0-wmf.24] ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping

https://gerrit.wikimedia.org/r/1275760

gerritbot added a comment.Tue, Apr 21, 8:09 AM

Change #1275760 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@wmf/1.46.0-wmf.24] ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping

https://gerrit.wikimedia.org/r/1275760

Stashbot added a comment.Tue, Apr 21, 8:10 AM

Mentioned in SAL (#wikimedia-operations) [2026-04-21T08:10:52Z] <musikanimal@deploy1003> Started scap sync-world: Backport for [[gerrit:1275760|ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping (T423773 T423756)]]

Stashbot mentioned this in T423756: AbuseFilter edit window cannot be resized horizontally.Tue, Apr 21, 8:10 AM

Mentioned in SAL (#wikimedia-operations) [2026-04-21T08:12:34Z] <musikanimal@deploy1003> musikanimal: Backport for [[gerrit:1275760|ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping (T423773 T423756)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Tue, Apr 21, 8:17 AM

Mentioned in SAL (#wikimedia-operations) [2026-04-21T08:17:54Z] <musikanimal@deploy1003> Finished scap sync-world: Backport for [[gerrit:1275760|ext.abuseFilter.edit.js: temporary locking of CodeMirror lineWrapping (T423773 T423756)]] (duration: 07m 01s)

MusikAnimal raised the priority of this task from High to Needs Triage.Tue, Apr 21, 6:43 PM

Hotfix deployed so the issue is not as pressing now. A more permanent fix, and one that allows disabling line wrapping, is still in-progress.

Mr._Starfleet_Command subscribed.Tue, Apr 21, 10:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits