some of the things we are doing in the cli are things like this:
filelog = (
args.filelog
if args.filelog is not None
else not _image_is_buildservice(args.image)
)
...
if stderr and not is_default_filelog_file(
filelog=stderr, jobname=jobname, filesuffix="err", toolname=toolname
):
job["filelog-stderr"] = shorten_filelog_path(filelog=stderr, toolname=toolname)We have code like this spread around the cli and api handling job field values. They were intentionally buggy and the only solution we had to the problem they were solving, until the storage was added to the api.
Since we now have storage, we should remove all of these.