Page MenuHomePhabricator

jobs-cli: stop resolving dynamic fields in the cli
Closed, ResolvedPublic

Description

some of the things we are doing in the cli are things like this:

 filelog = (
    args.filelog
    if args.filelog is not None
    else not _image_is_buildservice(args.image)
 )
...
if stderr and not is_default_filelog_file(
   filelog=stderr, jobname=jobname, filesuffix="err", toolname=toolname
):
    job["filelog-stderr"] = shorten_filelog_path(filelog=stderr, toolname=toolname)

We have code like this spread around the cli and api handling job field values. They were intentionally buggy and the only solution we had to the problem they were solving, until the storage was added to the api.

Since we now have storage, we should remove all of these.

Event Timeline

Raymond_Ndibe changed the task status from Open to In Progress.Apr 20 2026, 3:27 PM
Raymond_Ndibe moved this task from Backlog to In progress on the tools-platform-team board.
Raymond_Ndibe moved this task from In review to Done on the tools-platform-team board.
dcaro reassigned this task from Raymond_Ndibe to fnegri.
dcaro moved this task from Done to In progress on the tools-platform-team board.
dcaro reassigned this task from fnegri to Raymond_Ndibe.
dcaro moved this task from In progress to Done on the tools-platform-team board.