Page MenuHomePhabricator

HTML validation: Attribute width/height not allowed on element button at this point
Closed, ResolvedPublic

Description

Now that HTML5 is enabled, there are two endemic HTML validation errors:

  • Attribute width not allowed on element button at this point.
  • Attribute height not allowed on element button at this point.
  • validator.w3.org/check?uri=http%3A%2F%2Fwww.mediawiki.org%2Fwiki%2FSpecial%3ABlankPage

The issue is in the markup for the search button:

  • <button name="button" title="Search Wikipedia for this text" id="searchButton" width="12" height="13">

The width and height attributes are not valid for the button element:

The search icon is 12 x 13 pixels, thus this markup is not needed.

HTML validation is important. When editors manually create HTML ids, such as certain citation templates, we recommend they validate the page to ensure they have no duplicates. They get bogged down in endemic validation errors.


Version: 1.20.x
Severity: normal

Details

Reference
bz40384

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:02 AM
bzimport added a project: MediaWiki-General.
bzimport set Reference to bz40384.
bzimport added a subscriber: Unknown Object (MLST).
brion added a comment.Sep 20 2012, 9:24 PM

Hmmm...

Looks like UniversalEditButton may or may not have actually adopted the rel="edit" form -- http://universaleditbutton.org/Suggestions#Linking_Scheme lists it and includes a mention of me adding it, but http://universaleditbutton.org/Add_The_Link still lists the rel="alternate" format.

This is the kind of thing that's really meant to be open-ended though, I'm a bit baffled by the idea of rel values being registered. Is that new in HTML5-land?

brion added a comment.Sep 20 2012, 9:25 PM

Comment on wrong bug. :P

  • Bug 39521 has been marked as a duplicate of this bug. ***