Page MenuHomePhabricator

Move permission management from SpecialGlobalGroupPermissions into GlobalGroupLookup
Closed, ResolvedPublic

Description

Currently, the code which manages the global groups' permissions is coupled with special page for managing them, SpecialGlobalGroupPermissions. As part of the refactoring in the parent task, I'd like to move that service-like code to GlobalGroupLookup (which will thus become GlobalGroupManager).

Moving the code and making it a proper service will then make it easier to implement the further refactoring, by ensuring that manipulating the group properties will be done in a single class, so that any additional operations (like cache invalidation) can be coded there.

Event Timeline

Change #1275872 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] Rename GlobalGroupLookup to GlobalGroupManager

https://gerrit.wikimedia.org/r/1275872

Change #1275873 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] Rename references to GlobalGroupLookup with GlobalGroupManager

https://gerrit.wikimedia.org/r/1275873

Change #1275874 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] Add group management code to GlobalGroupManager

https://gerrit.wikimedia.org/r/1275874

Change #1275872 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Rename GlobalGroupLookup to GlobalGroupManager

https://gerrit.wikimedia.org/r/1275872

Change #1277117 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/WikimediaEvents@master] Rename references to GlobalGroupLookup with GlobalGroupManager

https://gerrit.wikimedia.org/r/1277117

Change #1275873 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Rename references to GlobalGroupLookup with GlobalGroupManager

https://gerrit.wikimedia.org/r/1275873

Change #1277117 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Rename references to GlobalGroupLookup with GlobalGroupManager

https://gerrit.wikimedia.org/r/1277117

Change #1276528 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] Update SpecialGlobalGroupPermissions to use GlobalGroupManager

https://gerrit.wikimedia.org/r/1276528

Change #1275874 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Add group management code to GlobalGroupManager

https://gerrit.wikimedia.org/r/1275874

Change #1276528 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Update SpecialGlobalGroupPermissions to use GlobalGroupManager

https://gerrit.wikimedia.org/r/1276528