Page MenuHomePhabricator

[Share Highlights] Render article-level share
Closed, ResolvedPublic3 Estimated Story Points

Description

Article-level share shows up when the user clicks on the share button in Minerva, as per T423858: [Share Highlights] Add a "Share" button to mobile article toolbar.

Design spec.

Acceptance criteria

  • shared text has a bolded article title
  • shared text is truncated if it's more than 7 lines

[X?] no article title is displayed in the branding container (no change from before, it was already like this)
[X?] the full Wikipedia wordmark is displayed instead (no change from before, it was already like this)

  • optimize/combine API calls as needed - done as part of T423861

Event Timeline

mfossati renamed this task from [ to [Share Highlights] Render article-level share.Mon, Apr 20, 11:49 AM
mfossati updated the task description. (Show Details)
mfossati moved this task from Incoming/Inbox to Needs Refinement on the Reader Growth Team board.

Change #1277767 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/ReaderExperiments@master] [Share Highlight] article share design cleanup

https://gerrit.wikimedia.org/r/1277767

Change #1277767 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] [Share Highlight] article share design cleanup

https://gerrit.wikimedia.org/r/1277767

lwatson subscribed.
QA
(1) Article title is bold
  • Test on beta and locally.
  • The article-level share card boldens the article title in the text. ✅
(2) Text is truncated
  • Test on beta and locally.
  • Text is truncated at 7 lines. ✅

ShareHighlight_article-level_card.png (1×1 px, 238 KB)

Notes

Filed bug T424787: Share Highlight: article title should not be bold within card when text is selected

lwatson closed this task as Resolved.EditedWed, Apr 29, 4:13 PM

Plan to work on the bug T424787 in the next sprint