Page MenuHomePhabricator

BadEmailDomainHookHandlerTest does not restore RequestContext main request
Closed, ResolvedPublic

Description

When running all of the tests locally in the WikimediaCustomizations, I am seeing an error caused by BadEmailDomainHookHandlerTest not restoring the original $request to the RequestContext after the test.

Fatal error: Uncaught TypeError: MediaWiki\User\User::getName(): Return value must be of type string, null returned in /var/www/html/w/includes/User/User.php on line 1537

TypeError: MediaWiki\User\User::getName(): Return value must be of type string, null returned in /var/www/html/w/includes/User/User.php on line 1537

Call Stack:
    2.8435   75321648   1. MediaWiki\Session\SessionManager->shutdown() /var/www/html/w/includes/Session/SessionManager.php:0
    2.8436   75321584   2. MediaWiki\Session\SessionBackend->shutdown() /var/www/html/w/includes/Session/SessionManager.php:551
    2.8436   75321584   3. MediaWiki\Session\SessionBackend->save($closing = TRUE) /var/www/html/w/includes/Session/SessionBackend.php:256
    2.8437   75323296   4. MediaWiki\User\User->getName() /var/www/html/w/includes/Session/SessionBackend.php:828

Event Timeline

Change #1275398 had a related patch set uploaded (by Aude; author: Aude):

[mediawiki/extensions/WikimediaCustomizations@master] Restore RequestContext $request in BadEmailDomainHookHandlerTest

https://gerrit.wikimedia.org/r/1275398

Change #1275398 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] Avoid accessing RequestContext in BadEmailDomainHookHandlerTest unit test

https://gerrit.wikimedia.org/r/1275398

matmarex assigned this task to aude.
matmarex subscribed.