Page MenuHomePhabricator

Fix GatewayChooser method/submethod logic so submethod config always takes priority
Closed, ResolvedPublic

Description

In DonationInterface gatweay config yaml files, we can specify support for countries, currencies, and recurring both at the submethod and at the method level. Submethod-level config is supposed to override method-level config, but our logic only lets that work when the submethod-level config is more restrictive than method-level.

e.g. if you say cards support recurring but visa-debit does not, that will work. However, if you say rtbt does not support recurring, except sepadirectdebit does, that config will fail.

Related Objects

Event Timeline

SBurnett-WMF moved this task from Triage to Next on the Fundraising-Backlog board.

Change #1318783 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] GatewayRouter: Submethod can positively override method

https://gerrit.wikimedia.org/r/1318783

Change #1318783 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] GatewayRouter: Submethod can positively override method

https://gerrit.wikimedia.org/r/1318783

XenoRyet set Final Story Points to 2.