Page MenuHomePhabricator

Suggestion Mode toggle gets stuck after acting on citation suggestion
Open, Needs TriagePublic2 Estimated Story Points

Description

Behavior

  1. Confirm suggestion mode is enabled
  2. Select a suggestion to add a citation
  3. Click "Add citation"
  4. Try toggling state from enabled to disabled

❗️ Actual

  1. Bulb goes grey to communicate that it's been disabled while suggestion side nav and citation popup remains

image.png (1×3 px, 455 KB)

✅ Expected

  1. All suggestion mode affordances are closed out

Event Timeline

ppelberg set the point value for this task to 2.Wed, Apr 29, 5:24 PM

The current behaviour doesn't seem that unreasonable - you are in the middle of interacting with a suggestion, so closing that dialog might unexpectedly lose progress.

Arguably you could disable the toggle button when it is in a state where it shouldn't be disabled.