Page MenuHomePhabricator
Create Task
Maniphest T424101

Suggestion Mode toggle gets stuck after acting on citation suggestion
Open, Needs TriagePublic2 Estimated Story Points
Actions

Description

Behavior

  1. Confirm suggestion mode is enabled
  2. Select a suggestion to add a citation
  3. Click "Add citation"
  4. Try toggling state from enabled to disabled

❗️ Actual

  1. Bulb goes grey to communicate that it's been disabled while suggestion side nav and citation popup remains

image.png (1×3 px, 455 KB)

✅ Expected

  1. All suggestion mode affordances are closed out

Related Objects
Search...

Event Timeline

ppelberg created this task.Tue, Apr 21, 9:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Apr 21, 9:47 PM
ppelberg added a parent task: T414853: [MILESTONE] Deploy Suggestion Mode as a default-on feature..Tue, Apr 21, 9:47 PM
ppelberg mentioned this in T420268: Implement Suggestion Mode Toggle (v0.2).
ppelberg attached a referenced file: F74701470: image.png. (Show Details)
ppelberg moved this task from Decision to be made to Ready for Dev on the Editing-team (Editing-current-Q4-27Apr-8May-2026) board.Wed, Apr 29, 2:51 PM
ppelberg set the point value for this task to 2.Wed, Apr 29, 5:24 PM
Esanders subscribed.Fri, May 1, 2:58 PM

The current behaviour doesn't seem that unreasonable - you are in the middle of interacting with a suggestion, so closing that dialog might unexpectedly lose progress.

Arguably you could disable the toggle button when it is in a state where it shouldn't be disabled.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits