Page MenuHomePhabricator
Create Task
Maniphest T424203

Add a link suggestion: Update copy
Open, Needs TriagePublic
Actions

Assigned To
DLynch
Authored By
bmartinezcalvo
Apr 23 2026, 10:12 AM
Tags
Referenced Files
F82664429: CleanShot 2026-05-19 at 10.32.10@2x.png
Tue, May 19, 3:33 PM
F82655627: CleanShot 2026-05-19 at 09.41.10@2x.png
Tue, May 19, 2:42 PM
F82654811: CleanShot 2026-05-19 at 09.35.13@2x.png
Tue, May 19, 2:42 PM
F82655100: CleanShot 2026-05-19 at 09.37.51@2x.png
Tue, May 19, 2:42 PM
F82651402: CleanShot 2026-05-18 at 16.16.25@2x.png
Tue, May 19, 2:24 PM
F82479121: CleanShot 2026-05-18 at 16.43.59@2x.png
Mon, May 18, 9:45 PM
F82443535: image.png
Mon, May 18, 6:08 PM
F77448918: image.png
Apr 23 2026, 10:12 AM
View All 9 Files
Subscribers
Aklapper
bmartinezcalvo
DLynch
Esanders
LazyShrey
ppelberg
Quiddity

Description

Background

In T415321 we updated all suggestion copy to the same format. This task is to align the Add link suggestion to this format.

image.png (506×694 px, 113 KB)

Proposed change

image.png (584×714 px, 130 KB)

TitleAdd a link
DescriptionThis text does not link to another article. Add a link to help readers learn more about this topic.
Question before buttonsLink “<text>” to <article title>?
ButtonsAdd link / Dismiss
Footer textSuggested links are machine-generated. Review before adding.

Acceptance criteria (or Done)

  • Update the copy for Add link suggestion

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
SuggestedLinkEditCheck: remove the icons from the actionsmediawiki/extensions/VisualEditormaster+2 -4
SuggestedLinkEditCheck: update copymediawiki/extensions/VisualEditormaster+14 -3
editcheck: Update suggested link copymediawiki/extensions/VisualEditormaster+13 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

bmartinezcalvo created this task.Apr 23 2026, 10:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2026, 10:12 AM
bmartinezcalvo updated the task description. (Show Details)Apr 23 2026, 10:13 AM
bmartinezcalvo added subscribers: ppelberg, Quiddity, DLynch.
DLynch updated the task description. (Show Details)Apr 23 2026, 10:59 AM
LazyShrey claimed this task.Apr 30 2026, 1:12 AM
LazyShrey subscribed.

hello, i am submitting a patch for this issue, hope that works :)

gerritbot added a comment.Apr 30 2026, 1:36 AM

Change #1279533 had a related patch set uploaded (by LazyShrey; author: LazyShrey):

[mediawiki/extensions/VisualEditor@master] editcheck: Update suggested link copy

https://gerrit.wikimedia.org/r/1279533

gerritbot added a project: Patch-For-Review.Apr 30 2026, 1:36 AM
Esanders subscribed.Wed, May 13, 3:59 PM

"This text does not link..." sounds more natural to me, as we are talking about the behaviour of the text, rather than the connectivity of the pages.

ppelberg edited projects, added VisualEditor Suggestion Mode, Editing-team (Editing-Q4-11May-22May-2026); removed Editing-team.Thu, May 14, 4:23 AM
ppelberg moved this task from Decision to be made to Design Doing on the Editing-team (Editing-Q4-11May-22May-2026) board.
bmartinezcalvo updated the task description. (Show Details)Thu, May 14, 9:24 AM
bmartinezcalvo moved this task from Design Doing to Ready for Dev on the Editing-team (Editing-Q4-11May-22May-2026) board.
El T424203#11918314, @Esanders escribió:

"This text does not link..." sounds more natural to me, as we are talking about the behaviour of the text, rather than the connectivity of the pages.

It sounds good. I've updated the copy in the task's description to: "This text does not link to another article. Add a link to help readers learn more about this topic."

We can update the implementation with this new copy.

gerritbot added a comment.Thu, May 14, 10:28 AM

Change #1279533 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] editcheck: Update suggested link copy

https://gerrit.wikimedia.org/r/1279533

Maintenance_bot removed a project: Patch-For-Review.Thu, May 14, 10:30 AM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).Thu, May 14, 11:00 AM
Esanders updated the task description. (Show Details)Thu, May 14, 5:42 PM
bmartinezcalvo updated the task description. (Show Details)Mon, May 18, 6:08 PM
ppelberg updated the task description. (Show Details)Mon, May 18, 8:36 PM

Please consider the content of the text within the table of the task description's Requirements section final.

gerritbot added a comment.Mon, May 18, 8:55 PM

Change #1288984 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] SuggestedLinkEditCheck: update copy

https://gerrit.wikimedia.org/r/1288984

gerritbot added a project: Patch-For-Review.Mon, May 18, 8:55 PM
ppelberg added a parent task: T421968: [Suggestion] Deploy "Add a link" suggestion as a default-on suggestion.Mon, May 18, 9:32 PM
ppelberg updated the task description. (Show Details)
ppelberg mentioned this in T421968: [Suggestion] Deploy "Add a link" suggestion as a default-on suggestion.Mon, May 18, 9:36 PM
gerritbot added a comment.Mon, May 18, 9:37 PM

Change #1288989 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] SuggestedLinkEditCheck: remove the icons from the actions

https://gerrit.wikimedia.org/r/1288989

DLynch added a comment.Mon, May 18, 9:45 PM

With those patches, we're now to this state:

CleanShot 2026-05-18 at 16.43.59@2x.png (540×634 px, 61 KB)

gerritbot added a comment.Mon, May 18, 10:39 PM

Change #1288984 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] SuggestedLinkEditCheck: update copy

https://gerrit.wikimedia.org/r/1288984

gerritbot added a comment.Mon, May 18, 10:39 PM

Change #1288989 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] SuggestedLinkEditCheck: remove the icons from the actions

https://gerrit.wikimedia.org/r/1288989

Maintenance_bot removed a project: Patch-For-Review.Mon, May 18, 11:31 PM
bmartinezcalvo added a comment.EditedTue, May 19, 8:05 AM
El T424203#11933583, @DLynch escribió:

With those patches, we're now to this state:

CleanShot 2026-05-18 at 16.43.59@2x.png (540×634 px, 61 KB)

@DLynch thank you for sharing. Quick design review of the implemented state:

  • To align with the Revise Tone one, the footer should include the cdxIconRobot in icon-size-small
  • Footer text size should be font-size-small (12px on Vector22, 14px on Minerva)
  • (already said in other suggestions/checks) the description and question should be color-subtle (color-base in all the text makes the card too heavy)
  • The More options button should be aligned with the other buttons (not with the footer text)
DLynch added a comment.Tue, May 19, 2:24 PM

To align with the Revise Tone one, the footer should include the cdxIconRobot in icon-size-small

Tone also doesn't have the icon currently, I assume because it's actually sort of a pain to make it generic. (We have a generic "there is a footer", but we haven't implemented "there is a footer that needs a warning icon for ML content".)

Footer text-size is also consistent with Tone.

CleanShot 2026-05-18 at 16.16.25@2x.png (438×650 px, 42 KB)

(already said in other suggestions/checks) the description and question should be color-subtle (color-base in all the text makes the card too heavy)

Aren't we still debating that? I remember writing up a whole "that seems like a bad idea" answer elsewhere, since none of the content of these cards should be made harder-to-read...

gerritbot added a comment.Tue, May 19, 2:42 PM

Change #1289365 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] EditCheckActionWidget: adjust design of feedback menu button

https://gerrit.wikimedia.org/r/1289365

gerritbot added a project: Patch-For-Review.Tue, May 19, 2:42 PM
DLynch added a comment.Tue, May 19, 2:42 PM

For the suggestion feedback ... menu, that patch does this:

CleanShot 2026-05-19 at 09.37.51@2x.png (680×630 px, 85 KB)

And in German, since that's an easy way to get us to wide buttons that'll have to wrap:

CleanShot 2026-05-19 at 09.35.13@2x.png (862×642 px, 97 KB)

(I left the experimental warning in for those screenshots since that shows all the possible elements. It would more normally look like this:

CleanShot 2026-05-19 at 09.41.10@2x.png (576×640 px, 71 KB)
)

DLynch claimed this task.Tue, May 19, 2:47 PM
DLynch moved this task from Ready for Dev to Code review on the Editing-team (Editing-Q4-11May-22May-2026) board.
LazyShrey added a project: RoadToWiki.Tue, May 19, 2:57 PM
gerritbot added a comment.Tue, May 19, 3:32 PM

Change #1289377 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] EditCheckActionWidget: support setting an icon next to the footer

https://gerrit.wikimedia.org/r/1289377

DLynch added a comment.Tue, May 19, 3:33 PM

That patch adjusts the footer display:

CleanShot 2026-05-19 at 10.32.10@2x.png (562×646 px, 56 KB)

DLynch added a comment.Tue, May 19, 3:36 PM

@bmartinezcalvo if there's a ticket for more general design adjustments to the widget (for the footer and the suggestion-feedback icon), I could retag those patches against it.

bmartinezcalvo mentioned this in T426770: EditCheck + Suggestions: Update footer styles.Tue, May 19, 4:08 PM
bmartinezcalvo mentioned this in T426771: Suggestions: align "More options" button with the rest of buttons.Tue, May 19, 4:11 PM
El T424203#11937143, @DLynch escribió:

@bmartinezcalvo if there's a ticket for more general design adjustments to the widget (for the footer and the suggestion-feedback icon), I could retag those patches against it.

linking all tasks:

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits