Page MenuHomePhabricator
Create Task
Maniphest T424308

Lua nested multi-line comments are not highlighted properly in CodeMirror
Closed, ResolvedPublicBUG REPORT
Actions

Description

The following should be highlighitng like a comment block in Lua:

--[=[
This is a comment block.
This is a comment block.
This is a comment block.
]=]

However only the opening line --[=[ is highlight as such. The parser does seem to recover well with any subsequent code, at least.

This is reproducible with the upstream CodeMirror Lua stream parser.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
package: Upgrade to @codemirror/legacy-modes@6.5.3mediawiki/extensions/CodeMirrormaster+6 -6
Customize query in gerrit

Related Objects

Event Timeline

MusikAnimal created this task.Apr 24 2026, 4:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 24 2026, 4:42 AM
MusikAnimal moved this task from Backlog to Bugs on the MediaWiki-extensions-CodeMirror board.Apr 24 2026, 4:42 AM
Bhsd subscribed.Apr 24 2026, 5:45 AM

I have submitted a pull request to the upstream @codemirror/legacy-modes library.

Hakimi97 subscribed.Apr 24 2026, 6:34 AM
Bhsd changed the task status from Open to In Progress.Apr 24 2026, 11:07 PM
Bhsd claimed this task.
Bhsd merged a task: T424404: --[=[ ... ]=] long lua comments not properly highlighted.
Bhsd added a subscriber: Trappist_the_monk.
Mr._Starfleet_Command subscribed.Apr 26 2026, 4:30 AM
Bhsd updated the task description. (Show Details)Thu, May 14, 5:34 PM
gerritbot added a comment.Fri, May 15, 1:53 PM

Change #1287876 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] package: Upgrade to @codemirror/legacy-modes@6.5.3

https://gerrit.wikimedia.org/r/1287876

gerritbot added a project: Patch-For-Review.Fri, May 15, 1:53 PM
gerritbot added a comment.Fri, May 15, 5:50 PM

Change #1287876 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] package: Upgrade to @codemirror/legacy-modes@6.5.3

https://gerrit.wikimedia.org/r/1287876

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).Fri, May 15, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Fri, May 15, 6:30 PM
Bhsd closed this task as Resolved.Tue, May 19, 9:20 AM
Bhsd moved this task from Bugs to Done on the MediaWiki-extensions-CodeMirror board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits