Page MenuHomePhabricator

Create generic paragraph checking functionality, usable by any edit check that works on a per-paragraph basis
Closed, ResolvedPublic

Description

To facilitate refactoring checks to use the per-node cache from T415297, we want generic functionality available to handle the following:

  • checking paragraph-by-paragraph
  • caching the results of each paragraph on a per-node basis (so they persist even during editing, unless this paragraph is modified)
  • filtering to show actions only for modified paragraphs
  • filtering to show actions only for ranges that have not been dismissed

We will achieve this by creating a mixin class called ContentBranchNodeCheck.

Event Timeline

Change #1277260 had a related patch set uploaded (by Divec; author: Divec):

[mediawiki/extensions/VisualEditor@master] Create mixin ContentBranchNodeCheck for per-node checking

https://gerrit.wikimedia.org/r/1277260

Change #1277260 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Create mixin ContentBranchNodeCheck for per-node checking

https://gerrit.wikimedia.org/r/1277260

Change #1278486 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] ContentBranchNodeCheck: cope with null actions

https://gerrit.wikimedia.org/r/1278486

Change #1278486 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ContentBranchNodeCheck: cope with null actions

https://gerrit.wikimedia.org/r/1278486

Change #1278538 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.26] ContentBranchNodeCheck: cope with null actions

https://gerrit.wikimedia.org/r/1278538

Change #1278538 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.26] ContentBranchNodeCheck: cope with null actions

https://gerrit.wikimedia.org/r/1278538

Mentioned in SAL (#wikimedia-operations) [2026-04-28T20:41:49Z] <kemayo@deploy1003> Started scap sync-world: Backport for [[gerrit:1278538|ContentBranchNodeCheck: cope with null actions (T424416)]]

Mentioned in SAL (#wikimedia-operations) [2026-04-28T20:43:38Z] <kemayo@deploy1003> kemayo: Backport for [[gerrit:1278538|ContentBranchNodeCheck: cope with null actions (T424416)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-04-28T20:48:25Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1278538|ContentBranchNodeCheck: cope with null actions (T424416)]] (duration: 06m 36s)

Change #1262135 had a related patch set uploaded (by Divec; author: Divec):

[VisualEditor/VisualEditor@master] Rewrite ve.dm.Node#getOffset to use caching against subroot

https://gerrit.wikimedia.org/r/1262135

Change #1262135 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Rewrite ve.dm.Node#getOffset to use caching against subroot

https://gerrit.wikimedia.org/r/1262135

Change #1283698 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3e4d5a497)

https://gerrit.wikimedia.org/r/1283698

Change #1283698 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3e4d5a497)

https://gerrit.wikimedia.org/r/1283698

dchan added a project: Skipped QA.