| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Remove AmazonPay files | Jgleeson | wikimedia/fundraising/SmashPig | master | +0 -2 K | |
| Update psr/log to 3.0, remove Amazon Pay 1.0 SDK | Ejegg | wikimedia/fundraising/SmashPig | master | +23 -61 |
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| In Progress | Jdforrester-WMF | T397070 Upgrade monolog/monolog to 3.9.0 or later | |||
| Resolved | Fomafix | T356451 Upgrade psr/log to 3.x | |||
| Resolved | Ejegg | T424398 Allow psr/log v3 for DonationInterface extension | |||
| Resolved | Ejegg | T424497 Allow psr/log v3 for smashpig library |
Event Timeline
Comment Actions
Blocked upstream: https://github.com/CoderKungfu/php-queue/issues/65 (though upstream is apparently now us).
Comment Actions
Oh hey, I can close that php-queue issue - https://github.com/CoderKungfu/php-queue/commit/2c47686c20df3d1035243ebf57d426aa68b51195 fixed it last year.
Comment Actions
Yup! The issue now is (if I force "monolog/monolog": "^3.0.0" and allow psr/log 2 or 3):
- Root composer.json requires amzn/login-and-pay-with-amazon-sdk-php ^2.5 -> satisfiable by amzn/login-and-pay-with-amazon-sdk-php[2.5.0]. - Root composer.json requires monolog/monolog ^3.0.0 -> satisfiable by monolog/monolog[3.0.0, ..., 3.10.0]. - amzn/login-and-pay-with-amazon-sdk-php 2.5.0 requires psr/log ^1.0 -> satisfiable by psr/log[1.0.0, ..., 1.1.4]. - monolog/monolog[3.0.0, ..., 3.10.0] require psr/log ^2.0 || ^3.0 -> satisfiable by psr/log[2.0.0, 3.0.0, 3.0.1, 3.0.2].
https://packagist.org/packages/amzn/login-and-pay-with-amazon-sdk-php is marked as abandoned in favour of https://packagist.org/packages/amzn/amazon-pay-sdk-php which is itself marked as deprecated in favour of https://packagist.org/packages/amzn/amazon-pay-api-sdk-php.
Comment Actions
Sadly, they still haven't added calls to programmatically download reports from the marketplace web services endpoint. I gave up on my merge request to the original SDK after a couple years of rebases and just left smashpig pointing to my fork. I guess we'll just remove Amazon Pay support till there is enough donor demand.
Comment Actions
DonationInterface extension is using https://github.com/ejegg/login-and-pay-with-amazon-sdk-php for the amazon package
Comment Actions
Change #1286960 had a related patch set uploaded (by Ejegg; author: Ejegg):
[wikimedia/fundraising/SmashPig@master] Update psr/log to 3.0, remove Amazon Pay 1.0 SDK
Comment Actions
Change #1286960 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Update psr/log to 3.0, remove Amazon Pay 1.0 SDK
Comment Actions
Change #1298730 had a related patch set uploaded (by Jgleeson; author: Jgleeson):
[wikimedia/fundraising/SmashPig@master] Remove AmazonPay files
Comment Actions
Change #1298730 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Remove AmazonPay files