VisualEditor hCaptcha: Closing the save dialog mid hcaptcha execution causes future save dialogs to not allow saving edits
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Apr 27 2026, 4:25 PM

Project Tags

Referenced Files

	F78832472: mobile_hcaptcha_state_diagram.png
	Apr 30 2026, 10:19 AM

	F78358414: image.png
	Apr 27 2026, 4:25 PM

Subscribers

Aklapper

dom_walden

Dreamy_Jazz

Description

Summary

If a user is using the VisualEditor interface and a hCaptcha widget is being executed, then exiting the save dialog before the conclusion of the execution causes the promise returned by hcaptcha.execute to never resolve

Steps to reproduce

Enable hCaptcha on your wiki and make it trigger for all edits
Open the VisualEditor edit interface with an account that does not have the skipcaptcha right
Make some changes and then open the save dialog
Click "Save changes"
Press the "Esc" key while the save dialog has it's loading animation set
Reopen the save dialog

What happens?

The save dialog does not allow the user to proceed with their edit because the save dialog is still in the pending state:

Acceptance criteria

Closing the dialog mid hcaptcha execution should still allow the user to reopen the save dialog and submit the edit

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	VisualEditor hCaptcha: Reject execution promise if dialog closes	mediawiki/extensions/ConfirmEdit	master	+157 -22

Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Apr 27 2026, 4:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2026, 4:25 PM

kostajh edited projects, added: Product Safety and Integrity (Sprint Tulip (Apr 13 - May 1)); removed: Product Safety and Integrity.Apr 27 2026, 4:37 PM

Dreamy_Jazz claimed this task.Apr 27 2026, 4:42 PM

Dreamy_Jazz moved this task from Backlog to In progress on the Product Safety and Integrity (Sprint Tulip (Apr 13 - May 1)) board.

Dreamy_Jazz moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Tulip (Apr 13 - May 1)) board.Apr 27 2026, 5:29 PM

Change #1277644 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] VisualEditor hCaptcha: Reject execution promise if dialog closes

https://gerrit.wikimedia.org/r/1277644

gerritbot added a project: Patch-For-Review.Apr 27 2026, 5:29 PM

Change #1277644 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] VisualEditor hCaptcha: Reject execution promise if dialog closes

https://gerrit.wikimedia.org/r/1277644

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).Apr 29 2026, 9:01 AM

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2026, 9:31 AM

Dreamy_Jazz moved this task from Needs review to QA in Prod on the Product Safety and Integrity (Sprint Tulip (Apr 13 - May 1)) board.Apr 29 2026, 9:44 AM

Testing notes

It would be great to retest this on testwiki, trying to find as many places/states where you can cancel the hCaptcha loading or dismiss the challenge (particularly using esc or similar). The below diagram may give you some inspiration. We want make sure that a user can always successfully publish an edit.

I have tested locally. I tried to find all the states (see below) in which hCaptcha can trigger, pressing escape and seeing if I can then successfully publish my edit.