Page MenuHomePhabricator

[Share Highlights] Bug Bash
Closed, ResolvedPublic

Description

Bug bash parent ticket for experiment pre-launch

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedKSarabia-WMF
ResolvedBUG REPORTegardner
Resolvedmfossati
ResolvedKSarabia-WMF
Resolvedmfossati
ResolvedBUG REPORTlwatson
ResolvedBUG REPORTKSarabia-WMF
ResolvedBUG REPORTmfossati
ResolvedBUG REPORTmfossati
Resolvedmatthiasmullie
Resolvedlwatson
InvalidBUG REPORTNone
DuplicateBUG REPORTNone
ResolvedBUG REPORTegardner
Resolvedlwatson
InvalidBUG REPORTlwatson
ResolvedBUG REPORTmatthiasmullie
ResolvedBUG REPORTmatthiasmullie

Event Timeline

  • "Downloading..." loading message isn't localized

{couldn't get a screenshot in time}

  • dialogue is stuck to the bottom of viewport when it should be centre-aligned

IMG_0249.PNG (2×1 px, 735 KB)

  • dialogue is sometimes too large for the viewport

IMG_0248.PNG (2×1 px, 1 MB)

  • sizing/cropping is incorrect in some cases

IMG_0247.PNG (2×1 px, 895 KB)

IMG_0254.PNG (2×1 px, 844 KB)

IMG_0252.PNG (2×1 px, 240 KB)

  • Wikipedia logo styling doesn't follow through to download

wikipedia-quote-espressionismo.png (1×576 px, 718 KB)

  • Images with transparent background, e.g. diagrams, svgs don't display correctly 

wikipedia-quote-plasmodesma.png (1×576 px, 200 KB)

wikipedia-quote-materiale.png (1×576 px, 215 KB)

  • Font size doesn't decrease before truncation in non-image cards. Truncation should only happen when the font is the minimum size and there still isn't enough space.

IMG_0253.PNG (2×1 px, 238 KB)

  • "public domain" not localized

wikipedia-quote-materiale.png (1×576 px, 215 KB)

  • sending on iOS Messages sends 3 messages

IMG_0258.PNG (2×1 px, 2 MB)

  • images don't follow through on native share

IMG_0258.PNG (2×1 px, 2 MB)

  • average colours for logos

wikipedia-quote-pittura.png (1×576 px, 804 KB)

  • the smallest font size is too small. Minimum size should be 14px.

wikipedia-quote-espressionismo.png (1×576 px, 718 KB)

  • "Downloading..." loading message isn't localized

{couldn't get a screenshot in time}

  • dialogue is stuck to the bottom of viewport when it should be centre-aligned

IMG_0249.PNG (2×1 px, 735 KB)

  • dialogue is sometimes too large for the viewport

IMG_0248.PNG (2×1 px, 1 MB)

  • sizing/cropping is incorrect in some cases

IMG_0247.PNG (2×1 px, 895 KB)

Note that enwiki is still on wmf.1, so these may not occur anymore from Thu 14.

dialogue is stuck to the bottom of viewport when it should be centre-aligned

In Figma, the dialog is center-aligned to the viewport, whether mobile or desktop.
In code, the dialog is displayed as a bottom sheet on mobile, and center-aligned on larger screens based on this task T417102: [Share Highlights] Create dialog container for the share actions

Does this need to be addressed/must-have for the experiment launch?

dialogue is stuck to the bottom of viewport when it should be centre-aligned

In Figma, the dialog is center-aligned to the viewport, whether mobile or desktop.
In code, the dialog is displayed as a bottom sheet on mobile, and center-aligned on larger screens based on this task T417102: [Share Highlights] Create dialog container for the share actions

Does this need to be addressed/must-have for the experiment launch?

I would say yes, having the dialogue be a dialogue and not a bottom sheet is pretty important. The designs aren't meant for a bottom sheet, but rather for a dialogue. Even if we decided to keep the bottom sheet experience, I would want to tweak the designs to match.

Change #1287873 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Allow image to shrink as needed

https://gerrit.wikimedia.org/r/1287873

Change #1287874 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Use white background for images

https://gerrit.wikimedia.org/r/1287874

Issue in bug bashRe-checked May 20/2026Follow-up?
(1) > - [ ] "Downloading..." loading message isn't localized> {couldn't get a screenshot in time}> The message is "Generating image ..." for both Share/Download (added screenshot on May 15/2026)
Screenshot 2026-05-15 at 3.47.50 PM.png (1×722 px, 273 KB)
- translation is in place for it wiki
Screenshot 2026-05-20 at 11.41.49 AM.png (1×1 px, 538 KB)
; plwiki displays untranslated messages:
Screenshot 2026-05-20 at 11.37.03 AM.png (1×998 px, 671 KB)
"Generating image..." sounds a bit too technical. A user is sharing or downloading a card and might be unaware that, in fact, an image is generated.

DONE (2) checked for https://en.wikipedia.org/wiki/Art_music?mpo=share-highlight:treatment

  • dialogue is stuck to the bottom of viewport when it should be centre-aligned

IMG_0249.PNG (2×1 px, 735 KB)
|I saw the issue previously, but it seems that it's not reproducible anymore.

iPhone SE 375 x 667Pixel 8/9 412 x 912iPad (10th) 920 x 1180
Screenshot 2026-05-15 at 5.03.11 PM.png (1×792 px, 526 KB)
Screenshot 2026-05-15 at 5.04.23 PM.png (1×748 px, 470 KB)
Screenshot 2026-05-15 at 5.07.28 PM.png (1×1 px, 971 KB)

The cards without images are less tall, but still are displayed centered even when only few words are selected:

Screenshot 2026-05-15 at 5.14.08 PM.png (1×724 px, 173 KB)
Screenshot 2026-05-15 at 5.16.30 PM.png (1×744 px, 155 KB)

DONE (3)

  • dialogue is sometimes too large for the viewport

IMG_0248.PNG (2×1 px, 1 MB)

Cached articles on a device do show the issue. Below is the difference between the cached article share card and the same article share card after refreshing the page:

Android Galaxy S8 (real device) - notice that the img is too big and overflows the frame:
Screenshot_20260515-145842_Chrome.jpg (2×1 px, 727 KB)
the same page refreshed:
Screenshot_20260515-150056_Chrome.jpg (2×1 px, 559 KB)

(4)

  • sizing/cropping is incorrect in some cases

IMG_0247.PNG (2×1 px, 895 KB)

As in the previous two cases, seems to be not reproducible. There is a curios difference between "zoom in" for a page share card and a highlight share card, the latter depends also on the number of words selected.

Android Samsung S8 real device

Page card
Screenshot_20260515-150358_Chrome.jpg (2×1 px, 600 KB)
Highlight card
Screenshot_20260515-150433_Chrome.jpg (2×1 px, 737 KB)
Highlight card with two words
Screenshot_20260515-151607_Chrome.jpg (2×1 px, 765 KB)

DONE (5)

IMG_0254.PNG (2×1 px, 844 KB)

The correct style for a button is present on beta (also see T426269: Share Highlight: fix share floating button and text-only quote card border)

Screenshot 2026-05-15 at 5.47.58 PM.png (1×670 px, 211 KB)

DONE (6)

IMG_0252.PNG (2×1 px, 240 KB)

Corrected on beta:

Screenshot 2026-05-15 at 6.08.33 PM.png (1×692 px, 80 KB)

(7)

  • Wikipedia logo styling doesn't follow through to download

wikipedia-quote-espressionismo.png (1×576 px, 718 KB)

The Wikipedia logo doesn't look correct in the downloaded card or in the preview of a share card?

DONE(8)

  • Images with transparent background, e.g. diagrams, svgs don't display correctly 

wikipedia-quote-plasmodesma.png (1×576 px, 200 KB)

wikipedia-quote-materiale.png (1×576 px, 215 KB)

the examples in the above screenshots are:
https://it.wikipedia.org/wiki/Plasmodesma?mpo=share-highlight:treatment
https://it.wikipedia.org/wiki/Materiale?mpo=share-highlight:treatment

Another example of the issue https://it.wikipedia.org/wiki/Spazio_euclideo?mpo=share-highlight:treatment

Screenshot 2026-05-15 at 4.04.50 PM.png (900×1 px, 281 KB)

Re-checked on May 20/2026 - ✅ DONE

Screenshot 2026-05-20 at 11.59.16 AM.png (1×970 px, 319 KB)

(9)

  • Font size doesn't decrease before truncation in non-image cards. Truncation should only happen when the font is the minimum size and there still isn't enough space.

IMG_0253.PNG (2×1 px, 238 KB)

(10)

  • "public domain" not localized

(11)

wikipedia-quote-materiale.png (1×576 px, 215 KB)

(12)

  • sending on iOS Messages sends 3 messages

IMG_0258.PNG (2×1 px, 2 MB)

  • images don't follow through on native share

IMG_0258.PNG (2×1 px, 2 MB)

see T424667: [QA task] Share highlight - production check and T426344: [Share Highlights] Image is not showing in the Share card on certain clients

(13)

  • average colours for logos

wikipedia-quote-pittura.png (1×576 px, 804 KB)

Seems to be corrected - https://it.wikipedia.org/wiki/Pittura?mpo=share-highlight:treatment

Screenshot 2026-05-15 at 6.31.19 PM.png (789×337 px, 188 KB)
Screenshot 2026-05-15 at 6.31.48 PM.png (787×362 px, 224 KB)

(14)

  • the smallest font size is too small. Minimum size should be 14px.

wikipedia-quote-espressionismo.png (1×576 px, 718 KB)

(7)

> Wikipedia logo styling doesn't follow through to download

wikipedia-quote-espressionismo.png (1×576 px, 718 KB)
The Wikipedia logo doesn't look correct in the downloaded card or in the preview of a share card?

Correct. If you use a dark image where the contrasting text isn't black, the logo and attribution info is still black when it should be light. It looks like 13 fixed it. So disregard.

Based on what I see above, I think the only other issue still present is the font size issue @lwatson picked up.

Closing now. The above ticket will be updated to be separate from the bug bash because it is not a launch blocker

KSarabia-WMF claimed this task.