Bug bash parent ticket for experiment pre-launch
Description
Event Timeline
- "Downloading..." loading message isn't localized
{couldn't get a screenshot in time}
- dialogue is stuck to the bottom of viewport when it should be centre-aligned
- dialogue is sometimes too large for the viewport
- sizing/cropping is incorrect in some cases
- share button is a primary progressive button, when it should be a progressive-normal button with 99px border radius
- card outlines missing for non-image cards. They should have a 1px border: base #A2A9B1
- Wikipedia logo styling doesn't follow through to download
- Images with transparent background, e.g. diagrams, svgs don't display correctly
- Font size doesn't decrease before truncation in non-image cards. Truncation should only happen when the font is the minimum size and there still isn't enough space.
- "public domain" not localized
- "image" not localized{F81218532}
- sending on iOS Messages sends 3 messages
- images don't follow through on native share
- average colours for logos
- the smallest font size is too small. Minimum size should be 14px.
dialogue is stuck to the bottom of viewport when it should be centre-aligned
In Figma, the dialog is center-aligned to the viewport, whether mobile or desktop.
In code, the dialog is displayed as a bottom sheet on mobile, and center-aligned on larger screens based on this task T417102: [Share Highlights] Create dialog container for the share actions
Does this need to be addressed/must-have for the experiment launch?
I would say yes, having the dialogue be a dialogue and not a bottom sheet is pretty important. The designs aren't meant for a bottom sheet, but rather for a dialogue. Even if we decided to keep the bottom sheet experience, I would want to tweak the designs to match.
Change #1287873 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/extensions/ReaderExperiments@master] Allow image to shrink as needed
Change #1287874 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/extensions/ReaderExperiments@master] Use white background for images
| Issue in bug bash | Re-checked May 20/2026 | Follow-up? |
|---|---|---|
| (1) > - [ ] "Downloading..." loading message isn't localized> {couldn't get a screenshot in time}> The message is "Generating image ..." for both Share/Download (added screenshot on May 15/2026) | - translation is in place for it wiki ; plwiki displays untranslated messages: | "Generating image..." sounds a bit too technical. A user is sharing or downloading a card and might be unaware that, in fact, an image is generated. |
✅ DONE (2) checked for https://en.wikipedia.org/wiki/Art_music?mpo=share-highlight:treatment
|I saw the issue previously, but it seems that it's not reproducible anymore.
- dialogue is stuck to the bottom of viewport when it should be centre-aligned
| iPhone SE 375 x 667 | Pixel 8/9 412 x 912 | iPad (10th) 920 x 1180 |
|---|---|---|
The cards without images are less tall, but still are displayed centered even when only few words are selected:
✅ DONE (3)
- dialogue is sometimes too large for the viewport
Cached articles on a device do show the issue. Below is the difference between the cached article share card and the same article share card after refreshing the page:
| Android Galaxy S8 (real device) - notice that the img is too big and overflows the frame: | the same page refreshed: |
(4)
- sizing/cropping is incorrect in some cases
As in the previous two cases, seems to be not reproducible. There is a curios difference between "zoom in" for a page share card and a highlight share card, the latter depends also on the number of words selected.
Android Samsung S8 real device
| Page card | Highlight card | Highlight card with two words |
✅ DONE (5)
- share button is a primary progressive button, when it should be a progressive-normal button with 99px border radius
The correct style for a button is present on beta (also see T426269: Share Highlight: fix share floating button and text-only quote card border)
✅ DONE (6)
- card outlines missing for non-image cards. They should have a 1px border: base #A2A9B1
Corrected on beta:
(7)
- Wikipedia logo styling doesn't follow through to download
The Wikipedia logo doesn't look correct in the downloaded card or in the preview of a share card?
✅ DONE(8)
- Images with transparent background, e.g. diagrams, svgs don't display correctly
the examples in the above screenshots are:
https://it.wikipedia.org/wiki/Plasmodesma?mpo=share-highlight:treatment
https://it.wikipedia.org/wiki/Materiale?mpo=share-highlight:treatment
Another example of the issue https://it.wikipedia.org/wiki/Spazio_euclideo?mpo=share-highlight:treatment
Re-checked on May 20/2026 - ✅ DONE
(9)
- Font size doesn't decrease before truncation in non-image cards. Truncation should only happen when the font is the minimum size and there still isn't enough space.
(10)
- "public domain" not localized
(11)
- "image" not localized{F81218532}
(12)
- sending on iOS Messages sends 3 messages
- images don't follow through on native share
see T424667: [QA task] Share highlight - production check and T426344: [Share Highlights] Image is not showing in the Share card on certain clients
(13)
- average colours for logos
Seems to be corrected - https://it.wikipedia.org/wiki/Pittura?mpo=share-highlight:treatment
(14)
- the smallest font size is too small. Minimum size should be 14px.
(7)
> Wikipedia logo styling doesn't follow through to download
wikipedia-quote-espressionismo.png (1×576 px, 718 KB)
The Wikipedia logo doesn't look correct in the downloaded card or in the preview of a share card?
Correct. If you use a dark image where the contrasting text isn't black, the logo and attribution info is still black when it should be light. It looks like 13 fixed it. So disregard.
Based on what I see above, I think the only other issue still present is the font size issue @lwatson picked up.
Closing now. The above ticket will be updated to be separate from the bug bash because it is not a launch blocker
























