| SherryYang-WMF | |
| Apr 27 2026, 10:58 PM |
| F80140669: Screenshot 2026-05-07 at 10.25.15 AM.png | |
| May 7 2026, 2:27 PM |
| F80140608: Screenshot 2026-05-07 at 10.24.59 AM.png | |
| May 7 2026, 2:27 PM |
| F80139920: Screenshot 2026-05-07 at 10.12.45 AM.png | |
| May 7 2026, 2:27 PM |
| F80138931: two_words highlighting2.gif | |
| May 7 2026, 2:27 PM |
Current: Floating Action Button for Share Excerpt shows when only one word is selected
Expected: FAB shows only when 2+ words are selected since sharing intent is unlikely for selecting one word
Recommend using Intl.Segmenter to detect "word" count to handle zh text (needed for the experiment) and other languages that don't use regular word spacing.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ShareHighlight: text selection edge cases & word-based activation | mediawiki/extensions/ReaderExperiments | master | +257 -24 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T416432 [Epic] Share Card experiment | |||
| Resolved | KSarabia-WMF | T424591 [Share Highlights] Bug Bash | |||
| Resolved | mfossati | T424592 [Share Highlights] Only show FAB when 2+ words are selected |
Change #1278492 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):
[mediawiki/extensions/ReaderExperiments@master] ShareHighlight: text selection edge cases & word-based activation
Change #1278492 merged by jenkins-bot:
[mediawiki/extensions/ReaderExperiments@master] ShareHighlight: text selection edge cases & word-based activation
Checked on enwiki beta - the gif is below:
**//Note://**
There are plenty of cases where the rule - " Only show FAB when 2+ words are selected" is not followed, but for the first iteration of share highlight functionality the happy path for two-word only highlight limitation should suffice.
Cases where the two-word highlight rule might is "broken"
(1) Only picture is selected
(3) a picture and a word from caption is selected
Thanks for spotting these edge cases. I've pasted them in T425716: [Share Highlights] FAB display edge cases. Not an experiment's blocker.