Page MenuHomePhabricator
Create Task
Maniphest T424632

Remove unused code from Cite and VE after refactoring
Closed, ResolvedPublic
Actions

Description

We probably can …

  • … remove or inline a lot of unused or single-use code.
  • … reduce code duplication by introducing small helper functions.
  • … clarify the terminology we use across codebases to be more consistent and less ambiguous.

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Apr 28 2026, 9:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2026, 9:39 AM
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2026-04-27-Multicolor-Potatoes board.Apr 28 2026, 9:40 AM
gerritbot added a comment.Apr 28 2026, 9:42 AM

Change #1277561 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove docRefs property from ve.ui.MWReferenceEditPanel

https://gerrit.wikimedia.org/r/1277561

gerritbot added a project: Patch-For-Review.Apr 28 2026, 9:42 AM

Change #1277566 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Clarify terminology in ve.dm.InternalList & …NodeGroup

https://gerrit.wikimedia.org/r/1277566

gerritbot added a comment.Apr 28 2026, 9:42 AM

Change #1277567 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Add ve.dm.InternalList.getListGroupNames method

https://gerrit.wikimedia.org/r/1277567

gerritbot added a comment.Apr 28 2026, 9:43 AM

Change #1277560 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Reduce usages of MWDocumentReferences.static.refsForDoc

https://gerrit.wikimedia.org/r/1277560

gerritbot added a comment.Apr 28 2026, 9:43 AM

Change #1275908 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Move RefInfo related code into MWDataTransitionHelper

https://gerrit.wikimedia.org/r/1275908

gerritbot added a comment.Apr 28 2026, 9:43 AM

Change #1277428 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Move single-use ve.dm.MWDocumentReferences method to be private

https://gerrit.wikimedia.org/r/1277428

gerritbot added a comment.Apr 28 2026, 9:44 AM

Change #1270938 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Remove unused listKeyRegex from StubReferenceNode

https://gerrit.wikimedia.org/r/1270938

gerritbot added a comment.Apr 28 2026, 9:44 AM

Change #1180837 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Optimize/document ve.dm.InternalListNodeGroup implementation

https://gerrit.wikimedia.org/r/1180837

gerritbot added a comment.Apr 28 2026, 9:45 AM

Change #1170169 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Remove InternalList's dependency on document.buildingNodeTree

https://gerrit.wikimedia.org/r/1170169

gerritbot added a comment.Apr 28 2026, 9:46 AM

Change #1278352 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Reuse existing 'mwReference(sList)' constants where possible

https://gerrit.wikimedia.org/r/1278352

gerritbot added a comment.Apr 28 2026, 9:47 AM

Change #1278254 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Clarify listGroup, listKey, and listIndex terminology

https://gerrit.wikimedia.org/r/1278254

thiemowmde added a project: WMDE-TechWish-Maintenance.Apr 28 2026, 9:50 AM
thiemowmde updated the task description. (Show Details)
thiemowmde added subscribers: WMDE-Fisch, awight, Svanteschubert, MareikeHeuerWMDE.
WMDE-Fisch added a parent task: T424659: [Epic] Code cleanup for sub-referencing.Apr 28 2026, 1:20 PM
WMDE-Fisch added a project: Cite (Sub-referencing).
gerritbot added a comment.Apr 28 2026, 2:34 PM

Change #1277567 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Add ve.dm.InternalList.getListGroupNames method

https://gerrit.wikimedia.org/r/1277567

lilients_WMDE moved this task from Incoming to NOW on the Cite (Sub-referencing) board.Apr 28 2026, 4:02 PM
gerritbot added a comment.Apr 30 2026, 1:19 PM

Change #1280406 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b383986ee)

https://gerrit.wikimedia.org/r/1280406

gerritbot added a comment.Apr 30 2026, 1:46 PM

Change #1280406 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b383986ee)

https://gerrit.wikimedia.org/r/1280406

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).Apr 30 2026, 2:00 PM
gerritbot added a comment.May 5 2026, 9:17 AM

Change #1277566 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Clarify terminology in ve.dm.InternalList & …NodeGroup

https://gerrit.wikimedia.org/r/1277566

gerritbot added a comment.May 5 2026, 9:48 AM

Change #1278254 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Clarify listGroup, listKey, and listIndex terminology

https://gerrit.wikimedia.org/r/1278254

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12); removed: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).May 5 2026, 10:00 AM
gerritbot added a comment.May 6 2026, 10:22 AM

Change #1283698 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3e4d5a497)

https://gerrit.wikimedia.org/r/1283698

gerritbot added a comment.May 6 2026, 4:22 PM

Change #1283698 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3e4d5a497)

https://gerrit.wikimedia.org/r/1283698

gerritbot added a comment.May 11 2026, 2:59 PM

Change #1285837 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Use upstream ve.dm.InternalList.getListGroupNames

https://gerrit.wikimedia.org/r/1285837

gerritbot added a comment.May 11 2026, 4:05 PM

Change #1277428 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move single-use ve.dm.MWDocumentReferences method to be private

https://gerrit.wikimedia.org/r/1277428

gerritbot added a comment.May 11 2026, 4:05 PM

Change #1277560 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Reduce usages of MWDocumentReferences.static.refsForDoc

https://gerrit.wikimedia.org/r/1277560

gerritbot added a comment.May 11 2026, 5:34 PM

Change #1285837 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Use upstream ve.dm.InternalList.getListGroupNames

https://gerrit.wikimedia.org/r/1285837

gerritbot added a comment.May 11 2026, 5:34 PM

Change #1278352 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Reuse existing 'mwReference(sList)' constants where possible

https://gerrit.wikimedia.org/r/1278352

gerritbot added a comment.May 12 2026, 6:42 AM

Change #1277561 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove docRefs property from ve.ui.MWReferenceEditPanel

https://gerrit.wikimedia.org/r/1277561

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19); removed: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).May 12 2026, 7:00 AM
Tobi_WMDE_SW added a project: WMDE-TechWish-Sprint-2026-05-12-Fungi.May 12 2026, 9:04 AM
Tobi_WMDE_SW moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2026-05-12-Fungi board.
Tobi_WMDE_SW moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2026-05-12-Fungi board.
gerritbot added a comment.May 13 2026, 8:19 AM

Change #1270938 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Remove unused listKeyRegex from StubReferenceNode

https://gerrit.wikimedia.org/r/1270938

gerritbot added a comment.May 16 2026, 9:42 AM

Change #1287980 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8fbfb6a7c)

https://gerrit.wikimedia.org/r/1287980

gerritbot added a comment.Sat, May 16, 2:30 PM

Change #1287980 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8fbfb6a7c)

https://gerrit.wikimedia.org/r/1287980

gerritbot added a comment.Thu, May 28, 10:15 AM

Change #1275908 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] Move RefInfo related code into MWDataTransitionHelper

Reason:

Obsolete via I1d4a86d.

https://gerrit.wikimedia.org/r/1275908

gerritbot added a comment.Mon, Jun 1, 11:59 AM

Change #1180837 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Optimize/document ve.dm.InternalListNodeGroup implementation

https://gerrit.wikimedia.org/r/1180837

WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2026-05-12-Fungi board.Tue, Jun 2, 10:37 AM
gerritbot added a comment.Tue, Jun 2, 10:40 AM

Change #1170169 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Remove InternalList's dependency on document.buildingNodeTree

https://gerrit.wikimedia.org/r/1170169

WMDE-Fisch removed a project: Patch-For-Review.Tue, Jun 2, 11:00 AM
gerritbot added a comment.Fri, Jun 5, 3:05 PM

Change #1298305 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f49818bd3)

https://gerrit.wikimedia.org/r/1298305

gerritbot added a project: Patch-For-Review.Fri, Jun 5, 3:05 PM
gerritbot added a comment.Fri, Jun 5, 3:26 PM

Change #1298305 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f49818bd3)

https://gerrit.wikimedia.org/r/1298305

Maintenance_bot removed a project: Patch-For-Review.Fri, Jun 5, 3:31 PM
WMDE-Fisch closed this task as Resolved.Tue, Jun 9, 8:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits