Page MenuHomePhabricator

Always open dialog with summary when opening through toolbelt button
Closed, ResolvedPublic1 Estimated Story Points

Description

The share dialog can be opened in 2 ways:

  1. through the always-there toolbelt "share" icon
  2. through the floating button that appears when text is selected

And it can open in 2 states:

  1. with the article summary
  2. with the selected text

In the current code, the state that the dialog will be opened in depends on whether there was any text selected, not which button was pressed to open it.
It is therefor possible to open the dialog from the toolbelt "share" button and have it show with a selected text snippet (assuming any text was selected when pressing the button)
That is *not* meant to be possible.
The state in which the dialog opens needs to match the button used to open the article: toolbelt button always opens with the article summary; floating button always opens with selected text

Acceptance criteria

  • Opening the dialog through the toolbelt "share" icon opens it with the article summary when no article text is selected
  • Opening the dialog through the toolbelt "share" icon opens it with the article summary even when article text is selected
  • Opening the dialog through the floating button opens with the selected text, when article text is selected
  • Opening the dialog through the floating button without article text being selected is not possible

Event Timeline

Change #1278407 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Always open dialog with summary when opening through toolbelt button

https://gerrit.wikimedia.org/r/1278407

Change #1278407 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Always open dialog with summary when opening through toolbelt button

https://gerrit.wikimedia.org/r/1278407

Etonkovidova subscribed.

Checked on enwiki beta - no issues; the AC in the task description are marked as done.

The screenshots are added to illustrate the following cases

Opening the dialog through the toolbelt "share" icon opens it with the article summary when no article text is selectedOnly toolbelt Share button is clicked; no text is selected
Screenshot 2026-05-01 at 6.35.31 PM.png (1,131×925 px, 700 KB)
matches the article description matches the preview in Search:
Screenshot 2026-05-01 at 6.37.45 PM.png (873×743 px, 235 KB)
Opening the dialog through the toolbelt "share" icon opens it with the article summary even when article text is selectedText is selected and the toolbelt Share button is clicked. The share card displays the article description:
Screenshot 2026-05-01 at 6.36.11 PM.png (811×936 px, 570 KB)
Opening the dialog through the floating button opens with the selected text, when article text is selectedThe text is selected and the floating Share quote button is clicked. Highlighted text matches the text in the share card
Screenshot 2026-05-01 at 6.35.50 PM.png (834×922 px, 616 KB)
KSarabia-WMF subscribed.

LGTM. Signing off.