Page MenuHomePhabricator

TextMatchEditCheck: rename matchItem to matchRule
Closed, ResolvedPublic3 Estimated Story Points

Description

In discussions (both engineering and on-wiki) we've found we need to clarify that "a matchItem means a rule". Going forward it seems matchRule would be a much clearer name. The name matchItem is currently used in the configs on 4 wikis, so we should make this change before rolling out further.

Steps:

  • Change TextMatchEditCheck.js to expect the name matchRule in config — but to allow matchItem for backwards compatibility: gerrit:1278514
  • Once the change is merged and live, change the on-wiki config from matchItemto matchRule
  • Change TextMatchEditCheck.js to remove the backwards compatibility

Details

Event Timeline

dchan set the point value for this task to 3.Apr 28 2026, 3:53 PM

Change #1278514 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] TextMatchEditCheck: rename matchItem to matchRule

https://gerrit.wikimedia.org/r/1278514

Change #1278514 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] TextMatchEditCheck: rename matchItem to matchRule

https://gerrit.wikimedia.org/r/1278514

medelius added a project: Skipped QA.

Change #1287839 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/VisualEditor@master] Reflect T424678 in SpecialEditChecks

https://gerrit.wikimedia.org/r/1287839

Change #1287839 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Reflect T424678 in SpecialEditChecks

https://gerrit.wikimedia.org/r/1287839