Page MenuHomePhabricator
Create Task
Maniphest T424773

__NOCONTENTCONVERT__ is not honored in Parsoid
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ParsoidLanguageConverter: don't convert TOC if __NOCONTENTCONVERT__C. Scott Ananianmediawiki/corewmf/1.47.0-wmf.3+122 -1
ParsoidLanguageConverter: don't convert TOC if __NOCONTENTCONVERT__C. Scott Ananianmediawiki/coremaster+122 -1
Bump wikimedia/parsoid to 0.24.0-a2C. Scott Ananianmediawiki/vendorwmf/1.47.0-wmf.1+14 K -14 K
Bump wikimedia/parsoid to 0.24.0-a2C. Scott Ananianmediawiki/vendormaster+14 K -14 K
Set page properties corresponding to magic word behavior switchesC. Scott Ananianmediawiki/services/parsoidmaster+19 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Djido created this task.Apr 28 2026, 8:33 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptApr 28 2026, 8:33 PM
cscott subscribed.Apr 28 2026, 10:49 PM

oh, right, this is probably a side-effect of T373384: Parsoid doesn't properly handle double-underscore magic words.

cscott claimed this task.Apr 28 2026, 10:49 PM
cscott added a subtask: T373384: Parsoid doesn't properly handle double-underscore magic words.
cscott added projects: Content-Transform-Team (Work In Progress), Parsoid-Read-Views (Language Converter Support).
gerritbot added a comment.Apr 29 2026, 7:44 PM

Change #1279469 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Set page properties corresponding to magic word behavior switches

https://gerrit.wikimedia.org/r/1279469

gerritbot added a project: Patch-For-Review.Apr 29 2026, 7:44 PM
Djido added a comment.Apr 30 2026, 9:25 PM

Same for NOTC

gerritbot added a comment.May 1 2026, 4:43 AM

Change #1279469 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Set page properties corresponding to magic word behavior switches

https://gerrit.wikimedia.org/r/1279469

Maintenance_bot removed a project: Patch-For-Review.May 1 2026, 5:31 AM
cscott moved this task from Backlog to To Deploy on the Content-Transform-Team (Work In Progress) board.May 4 2026, 3:26 PM
gerritbot added a comment.May 7 2026, 7:44 PM

Change #1284813 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

gerritbot added a project: Patch-For-Review.May 7 2026, 7:44 PM
gerritbot added a comment.May 7 2026, 8:02 PM

Change #1284813 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

gerritbot added a comment.May 7 2026, 8:16 PM

Change #1284832 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

gerritbot added a comment.May 7 2026, 9:07 PM

Change #1284832 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

Stashbot mentioned this in T368724: Rendering diff on broken link with template (visual diff testing).May 7 2026, 9:15 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:15:34Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]

Stashbot mentioned this in T319058: ParserTests defaults to wgAllowExternalImages=true.May 7 2026, 9:15 PM
Stashbot mentioned this in T424446: Space added for no reason.
Stashbot mentioned this in T420336: mw-parsoid improvements.
Stashbot mentioned this in T425008: WrapSectionState crash: Wikimedia\Assert\InvariantException: Invariant failed: Expected only language variants to be missing about ids..
Stashbot mentioned this in T425107: __TOC__ not showing up in Parsoid on Norwegian Bokmål village pump pages.
Stashbot mentioned this in T425056: 1.46.0-wmf.26 broke itwiki's Template:Divisa calcio.
Stashbot mentioned this in T425731: CTT tasks week of 2026-05-01.
Stashbot mentioned this in T373384: Parsoid doesn't properly handle double-underscore magic words.
Stashbot mentioned this in T423701: Serialize ContentHolder (or at least its fragments) in ParserOutput.
Stashbot mentioned this in T423241: Thumbtime for TimedMedia no longer working.

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:17:28Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]] synced to the t

Stashbot added a comment.May 7 2026, 9:27 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:27:35Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)

Maintenance_bot removed a project: Patch-For-Review.May 7 2026, 9:31 PM
ABreault-WMF moved this task from To Deploy to To Verify on the Content-Transform-Team (Work In Progress) board.May 7 2026, 10:32 PM
ABreault-WMF subscribed.May 7 2026, 11:50 PM

Post deploy

https://sr.wikipedia.org/w/index.php?title=%D0%A0%D0%B0%D0%B7%D0%B3%D0%BE%D0%B2%D0%BE%D1%80_%D1%81_%D0%BA%D0%BE%D1%80%D0%B8%D1%81%D0%BD%D0%B8%D0%BA%D0%BE%D0%BC:%D0%82%D0%B8%D0%B4%D0%BE&variant=sr-ec&useparsoid=1#You_may_be_an_eligible_candidate_for_the_U4C_election is in latin script

but note that the TOC is being converted in Parsoid but not the legacy parser

Djido added a comment.May 8 2026, 1:50 AM

@cscott Seems that fix is not complete -- TOC is not honoring NOTC

cscott moved this task from To Verify to In Progress on the Content-Transform-Team (Work In Progress) board.May 11 2026, 3:39 PM
gerritbot added a comment.May 18 2026, 4:46 PM

Change #1288914 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParsoidLanguageConverter: don't convert TOC if __NOCONTENTCONVERT__

https://gerrit.wikimedia.org/r/1288914

gerritbot added a project: Patch-For-Review.May 18 2026, 4:46 PM
gerritbot added a comment.May 19 2026, 4:03 AM

Change #1288914 merged by jenkins-bot:

[mediawiki/core@master] ParsoidLanguageConverter: don't convert TOC if __NOCONTENTCONVERT__

https://gerrit.wikimedia.org/r/1288914

gerritbot added a comment.May 19 2026, 4:05 AM

Change #1289071 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@wmf/1.47.0-wmf.3] ParsoidLanguageConverter: don't convert TOC if __NOCONTENTCONVERT__

https://gerrit.wikimedia.org/r/1289071

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.4; 2026-05-26).May 19 2026, 5:00 AM
gerritbot added a comment.May 19 2026, 1:22 PM

Change #1289071 merged by jenkins-bot:

[mediawiki/core@wmf/1.47.0-wmf.3] ParsoidLanguageConverter: don't convert TOC if __NOCONTENTCONVERT__

https://gerrit.wikimedia.org/r/1289071

Stashbot added a comment.May 19 2026, 1:23 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-19T13:23:20Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1289070|Forward-compatibility for serialization of ContentHolder in ParserOutput (T423701)]], [[gerrit:1289071|ParsoidLanguageConverter: don't convert TOC if NOCONTENTCONVERT (T424773)]]

Stashbot added a comment.May 19 2026, 1:25 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-19T13:25:24Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1289070|Forward-compatibility for serialization of ContentHolder in ParserOutput (T423701)]], [[gerrit:1289071|ParsoidLanguageConverter: don't convert TOC if NOCONTENTCONVERT (T424773)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Maintenance_bot removed a project: Patch-For-Review.May 19 2026, 1:31 PM
Stashbot added a comment.May 19 2026, 1:36 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-19T13:36:16Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1289070|Forward-compatibility for serialization of ContentHolder in ParserOutput (T423701)]], [[gerrit:1289071|ParsoidLanguageConverter: don't convert TOC if NOCONTENTCONVERT (T424773)]] (duration: 12m 56s)

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19); removed: MW-1.47-notes (1.47.0-wmf.4; 2026-05-26).May 19 2026, 2:00 PM
cscott added a comment.May 20 2026, 1:46 PM

@Djido We should be honoring __NOCONTENTCONVERT__ on table of contents and the content, and __NOTITLECONVERT__ on the displayed title now (in 1.47.0-wmf.3, which should be on sr.wikipedia.org tomorrow).

cscott moved this task from In Progress to To Verify on the Content-Transform-Team (Work In Progress) board.May 26 2026, 2:57 PM
cscott closed this task as Resolved.Jun 5 2026, 11:51 PM
cscott mentioned this in T424370: [SR] Language Converter should run only on pages in main namespace.Sun, Jun 21, 4:43 PM
cscott mentioned this in T349137: Handle __NOCONTENTCONVERT__ in core, not Parsoid.
FriedrickMILBarbarossa moved this task from Backlog to Closed on the Serbian-Sites board.Tue, Jun 23, 12:00 PM
MSantos added a project: OKR-Work.Thu, Jul 9, 12:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits