[Share Highlights] Unsupported CSS "has" feature
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	SherryYang-WMF
	Apr 29 2026, 4:45 PM

Project Tags

Referenced Files

None

Subscribers

Description

The style linter invoked via npm run lint currently emits the following warning:

Running "stylelint:all" (stylelint) task
>> resources/experiments/shareHighlight/styles/app.less
>>   18:1  ⚠  Unexpected browser feature "css-has" is not supported by Edge 79-81,83-104, Firefox 49-120, Chrome 49-81,83-104, Safari 10-15,10.1,11.1,12.1,13.1,14.1,15.1,15.2-15.3, Safari on iOS                                                    plugin/no-unsupported-browser-features

https://caniuse.com/css-has says that Safari & other browsers on iOS <15.4 don't support the feature.
The reported global usage is 0.35%.

Acceptance criteria

Check if the feature is supported end exclude from the experiment accordingly

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
Also skip instrumentation for unsupported browsers	Marco Fossati	mediawiki/extensions/ReaderExperiments	wmf/1.47.0-wmf.2	+6 -0
ShareHighlight: exclude browsers that don't support CSS has	Marco Fossati	mediawiki/extensions/ReaderExperiments	wmf/1.47.0-wmf.2	+8 -1
Also skip instrumentation for unsupported browsers	Matthias Mullie	mediawiki/extensions/ReaderExperiments	master	+6 -0
ShareHighlight: exclude browsers that don't support CSS has	Marco Fossati	mediawiki/extensions/ReaderExperiments	master	+8 -1
ShareHighlight: exclude iOS < 15.4	Marco Fossati	mediawiki/extensions/ReaderExperiments	master	+34 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T416432 [Epic] Share Card experiment
Resolved	KSarabia-WMF	T424591 [Share Highlights] Bug Bash
Resolved	mfossati	T424873 [Share Highlights] Unsupported CSS "has" feature

Event Timeline

SherryYang-WMF created this task.Apr 29 2026, 4:45 PM

SherryYang-WMF updated the task description. (Show Details)

SherryYang-WMF triaged this task as Low priority.Apr 29 2026, 4:47 PM

SherryYang-WMF set the point value for this task to 1.

SherryYang-WMF raised the priority of this task from Low to Needs Triage.Apr 29 2026, 5:16 PM

SherryYang-WMF moved this task from Sprint 3 (Apr 29 - May 12) Q4 25/26 to Backlog on the Reader Growth Team board.

SherryYang-WMF edited projects, added: Reader Growth Team; removed: Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26).

mfossati renamed this task from iOS Safari bug with "has" in CSS to [Share Highlights] Unsupported CSS "has" feature.May 5 2026, 12:00 PM

mfossati updated the task description. (Show Details)

matthiasmullie triaged this task as Low priority.May 5 2026, 4:40 PM

matthiasmullie moved this task from Backlog to Ready on the Reader Growth Team board.

mfossati changed the task status from Open to In Progress.May 11 2026, 10:24 AM

mfossati claimed this task.

mfossati updated the task description. (Show Details)

mfossati edited projects, added: Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26); removed: Reader Growth Team.

mfossati moved this task from Committed to Doing on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.

Rather than checking for specific devices, I reckon we might prefer to check for support of the feature(s): https://developer.mozilla.org/en-US/docs/Web/API/CSS/supports_static

Change #1285873 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):

[mediawiki/extensions/ReaderExperiments@master] ShareHighlight: exclude iOS < 15.4

https://gerrit.wikimedia.org/r/1285873

gerritbot added a project: Patch-For-Review.May 11 2026, 5:28 PM

Change #1286317 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):

[mediawiki/extensions/ReaderExperiments@master] ShareHighlight: exclude browsers that don't support CSS has

https://gerrit.wikimedia.org/r/1286317

mfossati moved this task from Doing to Code Review on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.May 12 2026, 11:37 AM

Change #1285873 abandoned by Marco Fossati:

[mediawiki/extensions/ReaderExperiments@master] ShareHighlight: exclude iOS < 15.4

Reason:

In favor of 1286317

https://gerrit.wikimedia.org/r/1285873

Change #1286317 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] ShareHighlight: exclude browsers that don't support CSS has

https://gerrit.wikimedia.org/r/1286317

Maintenance_bot removed a project: Patch-For-Review.May 12 2026, 7:31 PM

Change #1286482 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Also skip instrumentation for unsupported browsers

https://gerrit.wikimedia.org/r/1286482

gerritbot added a project: Patch-For-Review.May 12 2026, 7:58 PM

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 12 2026, 8:00 PM

Change #1286482 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Also skip instrumentation for unsupported browsers

https://gerrit.wikimedia.org/r/1286482

mfossati moved this task from Code Review to QA on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.May 13 2026, 9:21 AM

mfossati added a project: FY2025-26 WE3.1 Engaging New Audiences.May 13 2026, 9:24 AM

Maintenance_bot removed a project: Patch-For-Review.May 13 2026, 9:31 AM

Change #1286846 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] ShareHighlight: exclude browsers that don't support CSS has

https://gerrit.wikimedia.org/r/1286846

Change #1286847 had a related patch set uploaded (by Marco Fossati; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] Also skip instrumentation for unsupported browsers

https://gerrit.wikimedia.org/r/1286847

Change #1286846 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] ShareHighlight: exclude browsers that don't support CSS has

https://gerrit.wikimedia.org/r/1286846

Change #1286847 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] Also skip instrumentation for unsupported browsers

https://gerrit.wikimedia.org/r/1286847

Maintenance_bot removed a project: Patch-For-Review.May 13 2026, 1:32 PM

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12); removed: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 13 2026, 2:00 PM

HSwan-WMF moved this task from QA to Signoff on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.May 13 2026, 4:08 PM

Verified that the share experiment is not initialized on an unsupported browser (iPad mini, software version 12, Safari). Using the URL param ?mpo=share-highlight:treatment, text selection did not trigger the floating share button.

Bug: The Minerva toolbelt share button is visible. This share button is not functional and should not be visible for unsupported browsers.
Filed follow up: T426360: Share Highlight: hide the share button in Minerva's toolbelt for unsupported browsers

[Share Highlights] Unsupported CSS "has" featureClosed, ResolvedPublic1 Estimated Story PointsActions