Page MenuHomePhabricator
Create Task
Maniphest T424999

When tapping "View suggestions" suggestion is not fully-visible (desktop)
Open, Needs TriagePublic
Actions

Description

Behavior

  1. Confirm suggestion mode is enabled
  2. Visit an article where ≥1 suggestion is available outside of your viewport
  3. Tap "View suggestions"
  4. Notice you are scrolled to the most proximate suggestion

❗️ Actual

  1. Suggestion you are scrolled to is NOT fully visible

Screenshot 2026-04-30 at 10.57.59.jpeg (2,580×796 px, 313 KB)

✅ Expected

  1. Suggestion you are scrolled to is NOT fully visible

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
EditCheck: Remove unnecessary scrollIntoView calculationsmediawiki/extensions/VisualEditormaster+1 -12
Update VE core submodule to master (2db0070d9)mediawiki/extensions/VisualEditormaster+1 -1
scrollSelectionIntoView: Do a refinement scroll if surface padding changesVisualEditor/VisualEditormaster+13 -4
Customize query in gerrit

Event Timeline

ppelberg created this task.Apr 30 2026, 3:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2026, 3:01 PM
ppelberg updated the task description. (Show Details)Apr 30 2026, 3:02 PM
ppelberg moved this task from Decision to be made to Ready for Dev on the Editing-team (Editing-Q4-11May-22May-2026) board.
gerritbot added a comment.Wed, May 13, 12:17 PM

Change #1286882 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] scrollSelectionIntoView: Do a refinement scroll if surface padding changes

https://gerrit.wikimedia.org/r/1286882

gerritbot added a project: Patch-For-Review.Wed, May 13, 12:17 PM
gerritbot added a comment.Wed, May 13, 1:04 PM

Change #1286916 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] EditCheck: Remove unnecessary scrollIntoView calculations

https://gerrit.wikimedia.org/r/1286916

Esanders claimed this task.Wed, May 13, 2:04 PM
Esanders moved this task from Ready for Dev to Code review on the Editing-team (Editing-Q4-11May-22May-2026) board.
gerritbot added a comment.Mon, May 18, 5:27 PM

Change #1286882 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] scrollSelectionIntoView: Do a refinement scroll if surface padding changes

https://gerrit.wikimedia.org/r/1286882

gerritbot added a comment.Wed, May 20, 1:26 AM

Change #1289455 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2db0070d9)

https://gerrit.wikimedia.org/r/1289455

gerritbot added a comment.Wed, May 20, 4:38 PM

Change #1289455 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2db0070d9)

https://gerrit.wikimedia.org/r/1289455

gerritbot added a comment.Tue, May 26, 3:04 PM

Change #1286916 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: Remove unnecessary scrollIntoView calculations

https://gerrit.wikimedia.org/r/1286916

Maintenance_bot removed a project: Patch-For-Review.Tue, May 26, 3:31 PM
Esanders edited projects, added: Editing-team (Editing-current-Q4-8Jun-19Jun-2026); removed: Editing-team (Editing-Q4-11May-22May-2026).Tue, Jun 9, 10:12 AM
Esanders moved this task from Decision to be made to QA on the Editing-team (Editing-current-Q4-8Jun-19Jun-2026) board.Tue, Jun 9, 10:17 AM
Esanders added a project: Editing QA.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits