Page MenuHomePhabricator

1.46.0-wmf.26 broke itwiki's Template:Divisa calcio
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The first image of the team's kit is displayed outside the infobox.

What should have happened instead?:
It should be displayed inside the infobox.
Legacy parser for comparison: https://it.wikipedia.org/wiki/Juventus_Football_Club?safemode=1&useparsoid=0

Other information (browser name/version, screenshots, etc.):

Schermata del 2026-05-01 09-33-14.png (1,355×972 px, 403 KB)

The issue has been reported by multiple people on itwiki. It affects articles that use {{Divisa calcio}} (via {{Squadra di calcio}}). It was noticed after the deployment of 1.46.0-wmf.26 and seems related to recent changes in Parsoid, as it does not happen when using the legacy parser.

Related Objects

Mentioned In
T426924: Template CSS rendered as plain text
T423241: Thumbtime for TimedMedia no longer working
T423701: Serialize ContentHolder (or at least its fragments) in ParserOutput
T373384: Parsoid doesn't properly handle double-underscore magic words
T425731: CTT tasks week of 2026-05-01
T425107: __TOC__ not showing up in Parsoid on Norwegian Bokmål village pump pages
T425008: WrapSectionState crash: Wikimedia\Assert\InvariantException: Invariant failed: Expected only language variants to be missing about ids.
T420336: mw-parsoid improvements
T424446: Space added for no reason
T319058: ParserTests defaults to wgAllowExternalImages=true
T424773: __NOCONTENTCONVERT__ is not honored in Parsoid
T368724: Rendering diff on broken link with template (visual diff testing)
Mentioned Here
T319058: ParserTests defaults to wgAllowExternalImages=true
T368724: Rendering diff on broken link with template (visual diff testing)
T373384: Parsoid doesn't properly handle double-underscore magic words
T420336: mw-parsoid improvements
T423241: Thumbtime for TimedMedia no longer working
T423701: Serialize ContentHolder (or at least its fragments) in ParserOutput
T424446: Space added for no reason
T424773: __NOCONTENTCONVERT__ is not honored in Parsoid
T425008: WrapSectionState crash: Wikimedia\Assert\InvariantException: Invariant failed: Expected only language variants to be missing about ids.
T425107: __TOC__ not showing up in Parsoid on Norwegian Bokmål village pump pages
T425731: CTT tasks week of 2026-05-01
T378906: Categories as link tags cause navboxes to have a rendering difference

Event Timeline

We debugged this and it is because the work from T378906 moves the <style> tag from outside the div tag into the div tag and in this case, since the style tag has CSS for the div tag that now swallows it (and as Isabelle noted: uses the :firstChild selector), CSS breaks. We'll fix it for next week's train at the latest.

Change #1281440 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Always create a span for rendering-transparent nodes stashing

https://gerrit.wikimedia.org/r/1281440

Change #1281440 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Always create a span for rendering-transparent nodes stashing

https://gerrit.wikimedia.org/r/1281440

I just wanted to note that a lot of other pages involving football clubs on it.wiki are affected by the same bug. As you can see here, there's even an example of a "double glitch", where not only the home kit in the infobox is "invisible", but a historic kit that was featured in the first section ("Storia") shows up at the top for some reason.

Page: Società Sportiva Arezzo

Screenshot 2026-04-30 at 10-04-28 Società Sportiva Arezzo - Wikipedia.png (1,033×801 px, 261 KB)

We have a potential fix merged, and we'll try to get it deployed Monday ... unless we can find a CSS fix for https://it.wikipedia.org/w/index.php?title=Template%3ADivisa_calcio/styles.css which we think is broken with the train. Let me play around with it a bit in my browser.

Probably editing:

.divisa-calcio > div:first-child {
	height: 120px;
	left: 0;
	margin: 0 auto;
	padding: 0;
	position: relative;
	top: 0;
	width: 100px;
}

/* nome divisa */
.divisa-calcio > div:nth-child(2) {
	padding-top: 0.6em;
	text-align: center;
}

to

.divisa-calcio > link ~ div:nth-child(2), .divisa-calcio > style ~ div:nth-child(2), .divisa-calcio > div:first-child {
	height: 120px;
	left: 0;
	margin: 0 auto;
	padding: 0;
	position: relative;
	top: 0;
	width: 100px;
}

/* nome divisa */
.divisa-calcio > link ~ div:nth-child(3), .divisa-calcio > style ~ div:nth-child(3), .divisa-calcio > div:nth-child(2) {
	padding-top: 0.6em;
	text-align: center;
}

Do you want to give that a try?

Once we roll out our fixes next week, you can revert the change.

Thank you @ssastry, I've just applied your workaround in the meantime!

Change #1284813 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

Change #1284813 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

Change #1284832 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

Change #1284832 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:15:34Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:17:28Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]] synced to the t

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:27:35Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)

Thank you @ssastry, I've just applied your workaround in the meantime!

The fixes rolled out. Can you remove the workarounds and test that the pages continue to render properly? Thanks!

Thank you @ssastry, I've just applied your workaround in the meantime!

The fixes rolled out. Can you remove the workarounds and test that the pages continue to render properly? Thanks!

Done and it looks like it worked (even after purging the cache). Thanks again

Excellent. Resolving this ticket.