Page MenuHomePhabricator

Replace [gs]etRawText with [gs]etContentHolderText globally
Closed, ResolvedPublic

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1163428, @ihurbain deprecated [gs]etRawText in favour of [gs]etContentHolderText. However, usages were not replaced. Let's do that under this ticket.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki/coremaster+2 -0
mediawiki/extensions/Mathmaster+8 -8
mediawiki/extensions/Kartographermaster+2 -2
mediawiki/extensions/Scribuntomaster+3 -3
mediawiki/extensions/ParserFunctionsmaster+2 -2
mediawiki/extensions/ProofreadPagemaster+1 -1
mediawiki/extensions/ContentTranslationmaster+1 -1
mediawiki/coremaster+2 -0
mediawiki/coremaster+145 -145
mediawiki/extensions/WikiLambdamaster+7 -7
mediawiki/extensions/SyntaxHighlight_GeSHimaster+1 -1
mediawiki/extensions/TextExtractsmaster+1 -1
mediawiki/extensions/Translatemaster+7 -6
mediawiki/extensions/Newslettermaster+1 -1
mediawiki/extensions/MassMessagemaster+1 -1
mediawiki/extensions/CiteThisPagemaster+1 -1
mediawiki/extensions/EventLoggingmaster+1 -1
mediawiki/extensions/JsonConfigmaster+4 -4
mediawiki/extensions/Wikibasemaster+19 -19
mediawiki/extensions/RSSmaster+1 -1
mediawiki/extensions/VisualEditormaster+2 -2
mediawiki/extensions/Wikistoriesmaster+1 -1
mediawiki/extensions/GeoDatamaster+1 -1
mediawiki/extensions/WikimediaCustomizationsmaster+4 -4
mediawiki/extensions/Citemaster+1 -1
mediawiki/extensions/LiquidThreadsmaster+2 -2
mediawiki/extensions/CommonsMetadatamaster+1 -1
mediawiki/extensions/DiscussionToolsmaster+1 -1
mediawiki/extensions/EntitySchemamaster+7 -7
mediawiki/extensions/Lintermaster+1 -1
mediawiki/extensions/CheckUsermaster+2 -2
mediawiki/extensions/Flowmaster+2 -2
mediawiki/extensions/FeaturedFeedsmaster+1 -1
Show related patches Customize query in gerrit

Event Timeline

Change #1281684 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/CheckUser@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281684

Change #1281685 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Cite@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281685

Change #1281686 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/CiteThisPage@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281686

Change #1281687 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/CommonsMetadata@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281687

Change #1281688 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/ContentTranslation@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281688

Change #1281689 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/DiscussionTools@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281689

Change #1281690 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/EntitySchema@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281690

Change #1281691 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/EventLogging@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281691

Change #1281692 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/FeaturedFeeds@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281692

Change #1281693 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Flow@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281693

Change #1281694 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/GeoData@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281694

Change #1281695 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/JsonConfig@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281695

Change #1281696 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Kartographer@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281696

Change #1281697 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Linter@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281697

Change #1281698 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/LiquidThreads@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281698

Change #1281699 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/MassMessage@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281699

Change #1281700 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Math@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281700

Change #1281701 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Newsletter@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281701

Change #1281702 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/ParserFunctions@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281702

Change #1281703 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/ProofreadPage@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281703

Change #1281704 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/RSS@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281704

Change #1281705 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Scribunto@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281705

Change #1281706 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281706

Change #1281707 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/TextExtracts@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281707

Change #1281708 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Translate@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281708

Change #1281709 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/VisualEditor@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281709

Change #1281710 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/WikiLambda@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281710

Change #1281711 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Wikibase@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281711

Change #1281712 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/WikimediaCustomizations@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281712

Change #1281713 had a related patch set uploaded (by Gerrit maintenance bot; author: Gerrit maintenance bot):

[mediawiki/extensions/Wikistories@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281713

Change #1281692 abandoned by Urbanecm:

[mediawiki/extensions/FeaturedFeeds@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281692

Change #1281715 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281715

Change #1281684 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281684

Change #1281693 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281693

Change #1281690 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281690

Change #1281697 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281697

Change #1281698 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281698

Change #1281689 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281689

Change #1281718 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] ParserOutput: Add @param-taint exec_html to setContentHolderText

https://gerrit.wikimedia.org/r/1281718

Change #1281694 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281694

Change #1281687 merged by jenkins-bot:

[mediawiki/extensions/CommonsMetadata@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281687

Change #1281685 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281685

Change #1281709 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281709

Change #1281713 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281713

Change #1281691 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281691

Change #1281712 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281712

Change #1281711 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281711

Change #1281699 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281699

Change #1281704 merged by jenkins-bot:

[mediawiki/extensions/RSS@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281704

Change #1281686 merged by jenkins-bot:

[mediawiki/extensions/CiteThisPage@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281686

Change #1281708 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281708

A_smart_kitten subscribed.

Just as a nitpick regarding the commit messages:

Replace [gs]etRawText with [gs]etContentHolderText

Hard deprecated in Ibc35c8,
but seemingly never followed by replaces of the old methods.

FWICS from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1163428/32/includes/parser/ParserOutput.php, these methods were only soft-deprecated (the addition of a @deprecated tag) in that patch, rather than hard-deprecated (emitting deprecation warnings).

Fair enough, apologies for missing that. Thanks for the correction, @A_smart_kitten!

Change #1281695 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281695

Change #1281701 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281701

Change #1281706 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281706

Change #1281707 merged by jenkins-bot:

[mediawiki/extensions/TextExtracts@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281707

Change #1281710 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281710

Change #1281718 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput: Add @param-taint exec_html to setContentHolderText

https://gerrit.wikimedia.org/r/1281718

Change #1281741 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] ParserOutput: Hard deprecate [gs]etRawText

https://gerrit.wikimedia.org/r/1281741

Change #1281715 merged by jenkins-bot:

[mediawiki/core@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281715

Change #1281688 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281688

Change #1281705 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281705

Change #1281703 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281703

Change #1281702 merged by jenkins-bot:

[mediawiki/extensions/ParserFunctions@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281702

Change #1281696 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281696

Change #1281700 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Replace [gs]etRawText with [gs]etContentHolderText

https://gerrit.wikimedia.org/r/1281700

Change #1281741 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput: Hard deprecate [gs]etRawText

https://gerrit.wikimedia.org/r/1281741