Page MenuHomePhabricator
Create Task
Maniphest T425271

Remove all deprecated code from GrowthExperiments and CommunityConfiguration (Wikimedia Hackathon 2026)
Closed, ResolvedPublic
Actions

Description

During Wikimedia-Hackathon-2026, @Urbanecm_WMF was removing all deprecated code from GrowthExperiments. This task exists to track that work from the Hackathon. As part of this effort, I also removed unused/unnecessary code, and migrated few classes to PHP property promotion.

This task should be resolved once the associated patches are merged, even if GrowthExperiments/CommunityConfiguration continue to include deprecated code.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
cleanup: Do not use deprecated ApiBase::PARAM_RANGE_ENFORCEmediawiki/extensions/GrowthExperimentsmaster+1 -1
cleanup: Remove calls to deprecated withConsecutivemediawiki/extensions/GrowthExperimentsmaster+26 -11
cleanup: Remove last deprecated call to StatusValue::getErrorsmediawiki/extensions/GrowthExperimentsmaster+10 -6
fix(refreshUserImpactData): Move check for replag to correct placemediawiki/extensions/GrowthExperimentsmaster+2 -1
cleanup: Do not use ActorMigration anymoremediawiki/extensions/GrowthExperimentsmaster+9 -35
cleanup: Do not use deprecated ways to link usersmediawiki/extensions/GrowthExperimentsmaster+12 -33
refactor: Use RedirectLookup to load the redirect targetmediawiki/extensions/GrowthExperimentsmaster+36 -2
refactor: Convert HelpPanel into a servicemediawiki/extensions/GrowthExperimentsmaster+200 -125
refactor(HelpPanel): Use services instead of static methodsmediawiki/extensions/GrowthExperimentsmaster+16 -4
refactor: Replace waitForReplication with non-deprecated equivalentmediawiki/extensions/GrowthExperimentsmaster+15 -9
refactor: Switch to PHP property promotion syntaxmediawiki/extensions/CommunityConfigurationmaster+39 -136
cleanup: Remove unused constructor dependenciesmediawiki/extensions/GrowthExperimentsmaster+50 -190
cleanup: Replace User::getRegistration() with UserRegistrationLookupmediawiki/extensions/GrowthExperimentsmaster+59 -61
cleanup: Replace User::newFrom* with appropriate new methodsmediawiki/extensions/GrowthExperimentsmaster+81 -109
cleanup: Remove unused deps from GrowthExperimentsUserImpactUpdatermediawiki/extensions/GrowthExperimentsmaster+3 -22
Show related patches Customize query in gerrit

Event Timeline

Urbanecm_WMF created this task.May 3 2026, 12:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2026, 12:09 PM
Urbanecm_WMF added a comment.EditedMay 3 2026, 12:14 PM

Already merged stuff:

I'll tag unmerged stuff with this task.

gerritbot added a comment.May 3 2026, 12:15 PM

Change #1281838 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] cleanup: Replace User::newFrom* with appropriate new methods

https://gerrit.wikimedia.org/r/1281838

gerritbot added a project: Patch-For-Review.May 3 2026, 12:15 PM

Change #1281893 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove unused deps from GrowthExperimentsUserImpactUpdater

https://gerrit.wikimedia.org/r/1281893

gerritbot added a comment.May 3 2026, 12:15 PM

Change #1281896 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove unused constructor dependencies

https://gerrit.wikimedia.org/r/1281896

gerritbot added a comment.May 3 2026, 12:15 PM

Change #1281897 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] cleanup: Replace User::getRegistration() with UserRegistrationLookup

https://gerrit.wikimedia.org/r/1281897

gerritbot added a comment.May 3 2026, 12:16 PM

Change #1281930 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] refactor: Convert HelpPanel into a service

https://gerrit.wikimedia.org/r/1281930

gerritbot added a comment.May 3 2026, 12:16 PM

Change #1281948 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] refactor(HelpPanel): Use services instead of static methods

https://gerrit.wikimedia.org/r/1281948

gerritbot added a comment.May 3 2026, 12:16 PM

Change #1281958 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] cleanup: Do not use deprecated ways to link users

https://gerrit.wikimedia.org/r/1281958

gerritbot added a comment.May 3 2026, 12:17 PM

Change #1281960 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] refactor: Use RedirectLookup to load the redirect target

https://gerrit.wikimedia.org/r/1281960

gerritbot added a comment.May 3 2026, 12:17 PM

Change #1281966 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] cleanup: Do not use ActorMigration anymore

https://gerrit.wikimedia.org/r/1281966

gerritbot added a comment.May 3 2026, 12:17 PM

Change #1281969 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] fix(refreshUserImpactData): Move check for replag to correct place

https://gerrit.wikimedia.org/r/1281969

gerritbot added a comment.May 3 2026, 12:17 PM

Change #1281970 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] refactor: Replace waitForReplication with non-deprecated equivalent

https://gerrit.wikimedia.org/r/1281970

Urbanecm_WMF renamed this task from Remove all deprecated code from GrowthExperiments (Wikimedia Hackathon 2026) to Remove all deprecated code from GrowthExperiments and CommunityConfiguration (Wikimedia Hackathon 2026).May 3 2026, 12:35 PM
Urbanecm_WMF added a project: Technical-Debt (Deprecation process).
Urbanecm_WMF updated the task description. (Show Details)
gerritbot added a comment.May 3 2026, 12:36 PM

Change #1281899 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@master] refactor: Switch to PHP property promotion syntax

https://gerrit.wikimedia.org/r/1281899

Urbanecm_WMF added a project: MediaWiki-extensions-CommunityConfiguration.May 3 2026, 12:37 PM
gerritbot added a comment.May 3 2026, 1:54 PM

Change #1281838 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup: Replace User::newFrom* with appropriate new methods

https://gerrit.wikimedia.org/r/1281838

gerritbot added a comment.May 3 2026, 1:54 PM

Change #1281893 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove unused deps from GrowthExperimentsUserImpactUpdater

https://gerrit.wikimedia.org/r/1281893

gerritbot added a comment.May 3 2026, 1:55 PM

Change #1281896 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove unused constructor dependencies

https://gerrit.wikimedia.org/r/1281896

gerritbot added a comment.May 3 2026, 1:56 PM

Change #1281897 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup: Replace User::getRegistration() with UserRegistrationLookup

https://gerrit.wikimedia.org/r/1281897

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).May 3 2026, 2:00 PM
gerritbot added a comment.May 3 2026, 2:18 PM

Change #1281899 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] refactor: Switch to PHP property promotion syntax

https://gerrit.wikimedia.org/r/1281899

gerritbot added a comment.May 3 2026, 6:21 PM

Change #1281970 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor: Replace waitForReplication with non-deprecated equivalent

https://gerrit.wikimedia.org/r/1281970

Urbanecm_WMF triaged this task as Medium priority.May 3 2026, 9:02 PM
Urbanecm_WMF moved this task from Backlog to Proposed Projects on the Wikimedia-Hackathon-2026 board.

Leaning towards even higher, given this touches almost all areas of GE (increasing the chance of merge conflicts).

gerritbot added a comment.May 3 2026, 9:48 PM

Change #1282054 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove last deprecated call to StatusValue::getErrors

https://gerrit.wikimedia.org/r/1282054

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (FY2025-26 Q4 Sprint 2) board.May 3 2026, 10:03 PM
gerritbot added a comment.May 3 2026, 10:32 PM

Change #1282059 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove calls to deprecated withConsecutive

https://gerrit.wikimedia.org/r/1282059

gerritbot added a comment.May 3 2026, 10:59 PM

Change #1282062 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] cleanup: Do not use deprecated ApiBase::PARAM_RANGE_ENFORCE

https://gerrit.wikimedia.org/r/1282062

Urbanecm_WMF added a comment.May 3 2026, 11:11 PM

The last remaining deprecated code (according to my PHPStorm's inspections) is this:

image.png (3,360×804 px, 262 KB)

I don't really know what to do with this. No straightforward alternative is documented, and the more I looked at it, the more it seems the only (semi)viable option is to create a schema "outside" of the analytics/legacy namespace. I don't want to do that, especially since Growth is internally discussing our general approach towards measuring things.

Urbanecm_WMF updated the task description. (Show Details)May 3 2026, 11:12 PM
EMcFarland-WMF subscribed.May 4 2026, 9:27 AM
Michael subscribed.May 11 2026, 10:40 AM
gerritbot added a comment.May 11 2026, 10:52 AM

Change #1281930 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor: Convert HelpPanel into a service

https://gerrit.wikimedia.org/r/1281930

gerritbot added a comment.May 11 2026, 10:52 AM

Change #1281948 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor(HelpPanel): Use services instead of static methods

https://gerrit.wikimedia.org/r/1281948

gerritbot added a comment.May 11 2026, 10:54 AM

Change #1281958 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup: Do not use deprecated ways to link users

https://gerrit.wikimedia.org/r/1281958

gerritbot added a comment.May 11 2026, 10:54 AM

Change #1281960 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor: Use RedirectLookup to load the redirect target

https://gerrit.wikimedia.org/r/1281960

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12); removed: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).May 11 2026, 11:00 AM
gerritbot added a comment.May 11 2026, 11:28 AM

Change #1281966 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup: Do not use ActorMigration anymore

https://gerrit.wikimedia.org/r/1281966

DMburugu moved this task from Code Review to Doing on the Growth-Team (FY2025-26 Q4 Sprint 2) board.May 11 2026, 11:56 AM
Urbanecm_WMF moved this task from Doing to Code Review on the Growth-Team (FY2025-26 Q4 Sprint 2) board.May 11 2026, 2:28 PM
gerritbot added a comment.May 11 2026, 3:42 PM

Change #1281969 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(refreshUserImpactData): Move check for replag to correct place

https://gerrit.wikimedia.org/r/1281969

gerritbot added a comment.May 11 2026, 3:43 PM

Change #1282054 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove last deprecated call to StatusValue::getErrors

https://gerrit.wikimedia.org/r/1282054

gerritbot added a comment.May 11 2026, 5:14 PM

Change #1282059 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove calls to deprecated withConsecutive

https://gerrit.wikimedia.org/r/1282059

gerritbot added a comment.May 11 2026, 5:35 PM

Change #1282062 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup: Do not use deprecated ApiBase::PARAM_RANGE_ENFORCE

https://gerrit.wikimedia.org/r/1282062

Maintenance_bot removed a project: Patch-For-Review.May 11 2026, 6:31 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (FY2025-26 Q4 Sprint 2) board.May 13 2026, 1:20 PM
DMburugu subscribed.Mon, May 18, 9:25 AM

Hey Martin, is there another step after deprecation or can I mark this as resolved. I believe if any issues occur as a result of deprecation, those can just get their own tickets.

DMburugu edited projects, added: Growth-Team (FY2025-26 Q4 Sprint 3); removed: Growth-Team (FY2025-26 Q4 Sprint 2).Tue, May 19, 3:39 PM
DMburugu moved this task from Incoming to QA on the Growth-Team (FY2025-26 Q4 Sprint 3) board.
Urbanecm_WMF closed this task as Resolved.Wed, May 20, 1:26 PM

Nothing else to do; if stuff breaks, we will notice it chores and handle it as separate tickets. Resolving.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits