Current behaviour
Currently CosmeticChangesToolkit.commonsfiledesc method is available for commons:commons site only
Expected behaviour
The mehtod should be available for other sites of the commons Family too like commons:test or commons:beta
Way to go
Instead using the sitename method in commonsfiledesc
if self.site.sitename() != u'commons:commons' ...
use the family name instead: self.site.family.name which is commons.
See also
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [FEAT] Enable commonsfiledesc for all Commons family sites | pywikibot/core | master | +1 -1 |
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
Change #1283850 had a related patch set uploaded (by MacaroniThrift1; author: MacaroniThrift1):
[pywikibot/core@master] [FEAT] Enable commonsfiledesc for all Commons family sites
@ MacaroniThrift1: thank you for your patch. You may add yourself to the AUTHORS.rst file.
Change #1283850 merged by Xqt:
[pywikibot/core@master] [FEAT] Enable commonsfiledesc for all Commons family sites