Page MenuHomePhabricator

Passing constant via reference in Title.php
Closed, ResolvedPublic

Description

Author: jamesmikedupont

Description:
cascade was passed as a constant, but it is expected to be a reference.
includes/Title.php line 2267

Untested Patch :
@@ -2263,7 +2263,8 @@ public function updateTitleProtection( $create_perm, $reason, $expiry ) {

$expiry = array( 'create' => $expiry );
$page = WikiPage::factory( $this );
  • $status = $page->doUpdateRestrictions( $limit, $expiry, false, $reason, $wgUser );

+ $cascade=false;// passed by reference to doUpdateRestrictions, dont pass constants
+ $status = $page->doUpdateRestrictions( $limit, $expiry, $cascade, $reason, $wgUser );

  return $status->isOK();

}

also here :
https://github.com/h4ck3rm1k3/mediawiki/commit/5cd7bccdb53389c8da58738924f10f9dc9465cb9


Version: 1.20.x
Severity: normal
OS: Linux
Platform: Other

Details

Reference
bz40542