Page MenuHomePhabricator

Special:NewPagesFeed keyword search should be case insensitive
Open, Needs TriagePublicFeature

Description

Requested by @Hey_man_im_josh on Discord

Why

  • more useful

What

  • Special:NewPagesFeed keyword search should be case insensitive. is currently case sensitive

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1283155 had a related patch set uploaded (by Neriah; author: n-michlol):

[mediawiki/extensions/PageTriage@master] NewPagesFeed: Make keyword search case insensitive

https://gerrit.wikimedia.org/r/1283155

Change #1283155 abandoned by Neriah:

[mediawiki/extensions/PageTriage@master] NewPagesFeed: Make keyword search case insensitive

https://gerrit.wikimedia.org/r/1283155

@neriah. If you want you can unabandon your patch, get your patch mostly working, then ping Umherirrender, who is pretty good with the query builder. That's what I was going to do once your patch was done. https://www.mediawiki.org/wiki/Manual:Database_access#Helpers may also be useful.

Change #1283155 restored by Neriah:

[mediawiki/extensions/PageTriage@master] NewPagesFeed: Make keyword search case insensitive

https://gerrit.wikimedia.org/r/1283155

This could be problematic to implement.

  • Using functions like LOWER does not use database index and makes the query very expensive, such expensive queries must be hidden behind $wgMiserMode and makes it unusable on wmf wikis like en.wikipedia.org (But the already used LIKE seems also expensive as it matches in the middle of text, so it could be okay for this extension).
  • Funtion LOWER behaviour depends on the collation of the database column, wmf wikis using binary collation to avoid any conversion, where lower does nothing.
    • It was removed from Special:NewPages with T298722 as it was broken on wikis trying to use it
  • Not sure how this works on postgres or sqlite

There is not so many about query builder as there is no function to build a lower case match.

Change #1283155 abandoned by Neriah:

[mediawiki/extensions/PageTriage@master] NewPagesFeed: Make keyword search case insensitive

Reason:

not for me

https://gerrit.wikimedia.org/r/1283155