Link-based edit checks are not dismissable
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DLynch
	May 6 2026, 6:31 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

dchan

DLynch

Description

The refactor in T424416 that created ContentBranchNodeCheck removed usage of getModifiedRanges from the checks it switched, which had the side-effect of making them no longer respect dismissal.

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
ContentBranchNodeCheck: use getModifiedAnnotationRanges	DLynch	mediawiki/extensions/VisualEditor	master	+31 -35
Save action filtering info in ContentBranchNodeCheck#onDocumentChange	DLynch	mediawiki/extensions/VisualEditor	wmf/1.47.0-wmf.1	+1 -1
Remove duplicate definition of EditCheckAction#isTagged	DLynch	mediawiki/extensions/VisualEditor	wmf/1.47.0-wmf.1	+0 -21
Remove duplicate definition of EditCheckAction#isTagged	Divec	mediawiki/extensions/VisualEditor	master	+0 -21
Save action filtering info in ContentBranchNodeCheck#onDocumentChange	Divec	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T424102: Deploy config change to stop "Exit the editor" survey (Phase 1)
Mentioned Here: T424102: Deploy config change to stop "Exit the editor" survey (Phase 1)
T424416: Create generic paragraph checking functionality, usable by any edit check that works on a per-paragraph basis

Event Timeline

DLynch created this task.May 6 2026, 6:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2026, 6:31 PM

Change #1283869 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] ContentBranchNodeCheck: use getModifiedAnnotationRanges

https://gerrit.wikimedia.org/r/1283869

gerritbot added a project: Patch-For-Review.May 6 2026, 6:31 PM

Change #1283945 had a related patch set uploaded (by Divec; author: Divec):

[mediawiki/extensions/VisualEditor@master] Remove duplicate definition of EditCheckAction#isTagged

https://gerrit.wikimedia.org/r/1283945

Change #1283945 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove duplicate definition of EditCheckAction#isTagged

https://gerrit.wikimedia.org/r/1283945

Change #1283957 had a related patch set uploaded (by Divec; author: Divec):

[mediawiki/extensions/VisualEditor@master] Save action filtering info in ContentBranchNodeCheck#onDocumentChange

https://gerrit.wikimedia.org/r/1283957

Change #1283957 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Save action filtering info in ContentBranchNodeCheck#onDocumentChange

https://gerrit.wikimedia.org/r/1283957

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).May 6 2026, 10:00 PM

Change #1284702 had a related patch set uploaded (by DLynch; author: Divec):

[mediawiki/extensions/VisualEditor@wmf/1.47.0-wmf.1] Remove duplicate definition of EditCheckAction#isTagged

https://gerrit.wikimedia.org/r/1284702

Change #1284703 had a related patch set uploaded (by DLynch; author: Divec):

[mediawiki/extensions/VisualEditor@wmf/1.47.0-wmf.1] Save action filtering info in ContentBranchNodeCheck#onDocumentChange

https://gerrit.wikimedia.org/r/1284703

Change #1284702 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.47.0-wmf.1] Remove duplicate definition of EditCheckAction#isTagged

https://gerrit.wikimedia.org/r/1284702

Change #1284703 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.47.0-wmf.1] Save action filtering info in ContentBranchNodeCheck#onDocumentChange

https://gerrit.wikimedia.org/r/1284703

Mentioned in SAL (#wikimedia-operations) [2026-05-07T20:42:34Z] <kemayo@deploy1003> Started scap sync-world: Backport for [[gerrit:1284575|Revert "Enable mobile editor abandonment survey on enwiki" (T424102)]], [[gerrit:1284702|Remove duplicate definition of EditCheckAction#isTagged (T425583)]], [[gerrit:1284703|Save action filtering info in ContentBranchNodeCheck#onDocumentChange (T425583)]]

Mentioned in SAL (#wikimedia-operations) [2026-05-07T20:44:15Z] <kemayo@deploy1003> esanders, kemayo: Backport for [[gerrit:1284575|Revert "Enable mobile editor abandonment survey on enwiki" (T424102)]], [[gerrit:1284702|Remove duplicate definition of EditCheckAction#isTagged (T425583)]], [[gerrit:1284703|Save action filtering info in ContentBranchNodeCheck#onDocumentChange (T425583)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be v

Mentioned in SAL (#wikimedia-operations) [2026-05-07T20:49:12Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1284575|Revert "Enable mobile editor abandonment survey on enwiki" (T424102)]], [[gerrit:1284702|Remove duplicate definition of EditCheckAction#isTagged (T425583)]], [[gerrit:1284703|Save action filtering info in ContentBranchNodeCheck#onDocumentChange (T425583)]] (duration: 06m 38s)