Page MenuHomePhabricator

Suggestion Mode feedback toasts block me from advancing to next suggestion
Open, Needs TriagePublic

Description

This task involves the work of reducing the amount of time the Suggestion Mode feedback toasts remain on-screen so that they remain informative while at the same time do not interfere with you moving on to review the next available suggestion.

Story

As someone who just finished acting on a Suggestion on mobile within a span of text in which ≥1 suggestions are available/present, I want to know that I've been successful in addressing said suggestion while at the same time not feeling like I'm being prevented from seeing the next available suggestions so that I can maintain momentum and feel in control of my editing experience.

Requirements

Current experience

https://youtube.com/shorts/dRYi6XvJvJ0?feature=share

Event Timeline

Change #1286870 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Move notification overlay up with surface padding

https://gerrit.wikimedia.org/r/1286870

We could solve this issue by moving the Toasts from bottom to top T426191 so they don't appear over the bottom sheet and other elements place at the bottom, like the "View suggestions" button.

ppelberg added a subscriber: Esanders.

We could solve this issue by moving the Toasts from bottom to top T426191 so they don't appear over the bottom sheet and other elements place at the bottom, like the "View suggestions" button.

@bmartinezcalvo: it looks like @Esanders implemented a potential fix. Can you please review it and share whether you think the approach is viable or whether you think we need to pursue what you described in T425597#11917236.

Test wiki created on Patch demo by BMartinezCalvo (WMF) using patch(es) linked to this task:
https://22eda92aee.catalyst.wmcloud.org/w/

@Esanders I've reviewed the implemented change and it works as following:

  1. When completing a check that belongs to a block with multiple checks/suggestions, a Toast appears and the remaining check/suggestion closes. This feels confusing since you need to find again the closed suggestion/check.
  2. When opening the remaining suggestion, the Toast appears above the bottom sheet to avoid covering it. This behavior works well and feels appropriate.

Grabación de pantalla 2026-05-19 a las 14.04.00.gif (670×1,196 px, 2 MB)

I wonder whether we could instead keep the remaining check/suggestion bottom sheet in that multi-check block open after completing the check, while displaying the Toast above it (as described in 2).

Per offline

@Esanders I've reviewed the implemented change and it works as following:

  1. When completing a check that belongs to a block with multiple checks/suggestions, a Toast appears and the remaining check/suggestion closes. This feels confusing since you need to find again the closed suggestion/check.
  2. When opening the remaining suggestion, the Toast appears above the bottom sheet to avoid covering it. This behavior works well and feels appropriate.

Grabación de pantalla 2026-05-19 a las 14.04.00.gif (670×1,196 px, 2 MB)

I wonder whether we could instead keep the remaining check/suggestion bottom sheet in that multi-check block open after completing the check, while displaying the Toast above it (as described in 2).

Per today's offline discussion, we consider the change Ed implemented sufficient to address the need this ticket articulates. As for point #1 @bmartinezcalvo
raised above, we'll revisit it as part of the broader effort to improve the clarity around navigating and publishing suggestions in T426778.