As I started working on it, I realized what we're building isn't really so much a "visual" mode as it is just adding a form. "Visual" implies WYSIWYG, as in you could click on the chart itself to add a label, etc.
Looking at T425608 may illustrate the problem better. Even in source editing, you can get the same preview. So really, our work is just supplying a form in place of a JSON editor.
Acceptance criteria
- Rename the "Visual edit" tab to "Edit with form", like we did for MediaWiki-extensions-CommunityRequests to more accurately reflects what we're offering.
Derived Requirement
- The editing interface must replace the "Visual edit" tab label with "Edit with form".
- The updated tab label must accurately communicate that the interface provides a form-based editing experience rather than a WYSIWYG visual editor.
- The renamed tab must remain accessible and functional in the same location as the previous "Visual edit" tab.
- Selecting the "Edit with form" tab must continue to open the existing form-based editing workflow without behavioral regressions.
- References to the previous "Visual edit" label within the related editing interface must be updated for consistency where applicable.
Test Steps
Test Case 1: Verify the "Visual edit" tab is renamed to "Edit with form"
- Open a page that supports the chart editing workflow.
- Navigate to the editing interface containing the editing tabs.
- Observe the tab labels.
- ✅❓❌⬜ AC1: The tab label displays "Edit with form" instead of "Visual edit".
Test Case 2: Verify the renamed tab remains functional
- Open a page that supports the chart editing workflow.
- Locate the "Edit with form" tab.
- Select the tab.
- Observe the editing interface that loads.
- ✅❓❌⬜ AC2: Selecting the "Edit with form" tab opens the form-based editing interface successfully.
Test Case 3: Verify tab placement remains consistent after renaming
- Open a page that supports the chart editing workflow.
- Locate the editing tabs.
- Compare the placement of the "Edit with form" tab with expected tab ordering.
- ✅❓❌⬜ AC3: The "Edit with form" tab appears in the same interface location previously used by "Visual edit".
Test Case 4: Verify the editing experience is form-based and not WYSIWYG
- Open the "Edit with form" tab on a supported page.
- Observe the editing controls presented to the user.
- Attempt to directly manipulate chart content visually.
- ✅❓❌⬜ AC4: The interface presents structured form inputs rather than direct WYSIWYG editing controls.
QA Results - Local
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T425688#11923407 |
| 2 | ✅ | T425688#11920179 |
| 3 | ✅ | T425688#11920179 |
| 4 | ✅ | T425688#11920179 |
