Page MenuHomePhabricator

Endroid\QrCode\Builder\Builder::buildObject(): Implicitly marking parameter $optionsPrefix as nullable is deprecated, the explicit nullable type must be used instead
Open, Needs TriagePublic

Description

I think this becomes a mix of dependancy annoyances...

21:18:56 1) MediaWiki\Extension\OATHAuth\Tests\Integration\Special\OATHManageTest::testPageLoads
21:18:56 Endroid\QrCode\Builder\Builder::buildObject(): Implicitly marking parameter $optionsPrefix as nullable is deprecated, the explicit nullable type must be used instead
21:18:56 
21:18:56 /workspace/src/vendor/endroid/qr-code/src/Builder/Builder.php:249
21:18:56 /workspace/src/extensions/OATHAuth/src/HTMLForm/TOTPEnableForm.php:62
21:18:56 /workspace/src/extensions/OATHAuth/src/HTMLForm/OATHAuthOOUIHTMLForm.php:73
21:18:56 /workspace/src/extensions/OATHAuth/src/Module/TOTP.php:114
21:18:56 /workspace/src/extensions/OATHAuth/src/Special/OATHManage.php:301
21:18:56 /workspace/src/extensions/OATHAuth/src/Special/OATHManage.php:192
21:18:56 /workspace/src/extensions/OATHAuth/src/Special/OATHManage.php:187
21:18:56 /workspace/src/extensions/OATHAuth/src/Special/OATHManage.php:124
21:18:56 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:121
21:18:56 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:51
21:18:56 /workspace/src/tests/phpunit/includes/specials/SpecialPageTestBase.php:76
21:18:56 /workspace/src/extensions/OATHAuth/tests/phpunit/integration/Special/OATHManageTest.php:51

This requires an update to the newer endroid/qr-code 6.x, but that drops support for PHP 8.1, which we need in 1.43 as well.
See also https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/1277146/1#message-0d017d1313c6fb1c48aa8d679b93c93090983d75