Page MenuHomePhabricator
Create Task
Maniphest T425760

🫛 Include the property data type in the search results
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Search: Include datatype in property prefix search resultsDima koushhamediawiki/extensions/Wikibasemaster+100 -20
Use Property-specific EntitySearchHelperSilvan Heintzemediawiki/extensions/WikibaseCirrusSearchmaster+10 -1
Search: Include datatype in property prefix search resultsSilvan Heintzemediawiki/extensions/Wikibasemaster+72 -22
Search: Separate DTOs for property search resultsSilvan Heintzemediawiki/extensions/Wikibasemaster+138 -144
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.May 8 2026, 9:58 AM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptMay 8 2026, 9:58 AM
Silvan_WMDE claimed this task.May 11 2026, 7:27 AM
Silvan_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 68) board.
Jakob_WMDE moved this task from Sprint 68 to Sprint 69 on the Wikibase Reuse Team board.May 11 2026, 12:25 PM
Jakob_WMDE edited projects, added: Wikibase Reuse Team (Sprint 69); removed: Wikibase Reuse Team (Sprint 68).
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 69) board.
gerritbot added a comment.May 13 2026, 7:31 AM

Change #1286752 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/WikibaseCirrusSearch@master] Use Property-specific EntitySearchHelper

https://gerrit.wikimedia.org/r/1286752

gerritbot added a project: Patch-For-Review.May 13 2026, 7:31 AM
gerritbot added a comment.May 13 2026, 7:39 AM

Change #1286756 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] Search: Separate DTOs for property search results

https://gerrit.wikimedia.org/r/1286756

gerritbot added a comment.May 13 2026, 7:39 AM

Change #1286757 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] Search: Include datatype in property prefix search results

https://gerrit.wikimedia.org/r/1286757

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 69) board.May 13 2026, 9:06 AM
Silvan_WMDE removed Silvan_WMDE as the assignee of this task.May 13 2026, 2:40 PM
Silvan_WMDE moved this task from Peer Review to To Do on the Wikibase Reuse Team (Sprint 69) board.
Silvan_WMDE subscribed.

Sadly, I am running out of time to properly finish this.

Following the review comment in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1286757, we believe this can be solved by removing the PropertyDataTypeSearchHelper completely and moving its logic of looking up the datatype for each result into the property part of our EntitySearchHelperPrefixSearchEngine.

Jakob_WMDE closed this task as Resolved.May 18 2026, 7:48 AM
Jakob_WMDE reopened this task as Open.
Jakob_WMDE claimed this task.
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 69) board.
gerritbot added a comment.May 18 2026, 10:09 AM

Change #1286756 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Separate DTOs for property search results

https://gerrit.wikimedia.org/r/1286756

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 18 2026, 11:00 AM
Dima_Koushha_WMDE claimed this task.May 18 2026, 12:50 PM
gerritbot added a comment.May 20 2026, 11:22 AM

Change #1286757 abandoned by Dima koushha:

[mediawiki/extensions/Wikibase@master] Search: Include datatype in property prefix search results

Reason:

not needed anymore

https://gerrit.wikimedia.org/r/1286757

gerritbot added a comment.May 20 2026, 11:23 AM

Change #1286752 abandoned by Dima koushha:

[mediawiki/extensions/WikibaseCirrusSearch@master] Use Property-specific EntitySearchHelper

Reason:

not needed anymore

https://gerrit.wikimedia.org/r/1286752

gerritbot added a comment.May 20 2026, 11:28 AM

Change #1289925 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] Search: Include datatype in property prefix search results

https://gerrit.wikimedia.org/r/1289925

Dima_Koushha_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 69) board.May 20 2026, 11:56 AM
gerritbot added a comment.May 20 2026, 2:53 PM

Change #1289925 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Include datatype in property prefix search results

https://gerrit.wikimedia.org/r/1289925

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.4; 2026-05-26); removed: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 20 2026, 3:00 PM
Dima_Koushha_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 69) board.May 20 2026, 3:05 PM
Maintenance_bot removed a project: Patch-For-Review.May 20 2026, 3:30 PM
Ifrahkhanyaree_WMDE closed this task as Resolved.May 29 2026, 11:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits