Page MenuHomePhabricator
Create Task
Maniphest T425828

Freeze leftmost columns (checkbox, status, photo, side-panel) when horizontally scrolling the table
Closed, ResolvedPublic
Actions

Description

In the spreadsheet/table view, when a user has many metadata columns enabled and scrolls horizontally, they lose sight of which row they're editing because the photo and row-level controls scroll off the left edge. Pin the four leftmost "row identity / row action" columns so they stay in place while the metadata columns scroll underneath them, similar to Excel's Freeze Panes.

Columns to freeze (left → right):

  1. Selection checkbox
  2. Status indicator
  3. Photo thumbnail
  4. Open-side-panel button

Out of scope: Gallery/grid view (no horizontal scroll there).

Acceptance criteria:

  • In table view, scrolling horizontally keeps columns 1–4 visible against the left edge.
  • Vertical scroll still scrolls the whole row including the frozen columns.
  • Visual treatment makes the freeze boundary obvious (e.g. shadow / divider on the right edge of the frozen block).
  • No regression in row selection, status display, thumbnail click-through, or the side-panel toggle.

Source: User feedback session, 2026-05-08.

Related Objects

Event Timeline

Daanvr created this task.May 8 2026, 9:35 PM
Daanvr triaged this task as Medium priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2026, 9:35 PM
Daanvr moved this task from Backlog to To do on the Tool-upload-workbench board.May 9 2026, 7:00 AM
Daanvr claimed this task.May 9 2026, 7:51 AM
Daanvr moved this task from To do to Doing on the Tool-upload-workbench board.
Daanvr mentioned this in T425829: Category pill popover shows placeholder data; needs real Commons fetch + 'Open on Commons' link.May 9 2026, 8:02 AM
Daanvr moved this task from Doing to Needs input on the Tool-upload-workbench board.May 9 2026, 8:05 AM

@Daanvr — implementation done, MR open at https://gitlab.wikimedia.org/daanvr/upload-workbench/-/merge_requests/11.

Blocker — preview deploy serves the wrong HTML. https://upload-workbench.toolforge.org/mr-11/ returns a 200, but with root's index.html (etag e505bd38…, references /assets/index-DlCXJMMf.js) — not the MR build. The MR build's actual assets are present at /mr-11/assets/index-CQ0_y_6C.js (the hash printed by deploy:mr), so the rsync landed correctly; the issue is the toolforge web server serving root index.html for /mr-N/ paths.

Reproducible across all three open MR previews:

$ for url in / /mr-9/ /mr-10/ /mr-11/; do curl -sI "https://upload-workbench.toolforge.org$url" | grep etag; done
etag: "e505bd38793e8efa088ed44f6392f854ba39d408"
etag: "e505bd38793e8efa088ed44f6392f854ba39d408"
etag: "e505bd38793e8efa088ed44f6392f854ba39d408"
etag: "e505bd38793e8efa088ed44f6392f854ba39d408"

/v0.4.0/ returns a directory listing instead of its own index.html (similar root-cause: toolforge static server doesn't autoserve sub-dir index.html). Assets under /mr-11/assets/ resolve fine on direct access.

What I've tried: built locally (npm run build clean), glab ci trace deploy:mr shows the build ran with VITE_BASE_PATH=/mr-11/ and rsync placed files in /data/project/upload-workbench/www/static/mr-11/. The CI step is correct; the problem is server-side path routing on Toolforge.

Question: Is this a known infrastructure gap (the MR-preview feature shipped in v0.4.0 but the static-server config wasn't updated to autoserve sub-directory index.html), or is there a CI-side fix I'm missing? If known/expected, OK to push to Reviewing with the diff alone for now? Same blocker affects T425827 and T425829 (sibling subagents).

Daanvr mentioned this in T425851: Merge Request live previeuw bug.May 9 2026, 8:32 AM
Daanvr added a comment.May 9 2026, 8:34 AM

Acknowledged — saw the T425851 comment naming this task as unblocked, and verified my build via the nginx URL: https://tools-static.wmflabs.org/upload-workbench/mr-11/ returns HTML referencing /mr-11/assets/index-CxUVOTKD.js (matches the hash from deploy:mr's build log) — confirms the per-MR rsync placed the right build.

Ready to resume verification on upload-workbench.toolforge.org/mr-11/ the moment T425851 merges and you move this back to Doing. Continuing to poll.

Daanvr moved this task from Needs input to Reviewing on the Tool-upload-workbench board.May 9 2026, 10:52 AM

Preview infra fix !12 is merged & deployed; webservice restarted. Verified /mr-11/ now serves this MR's own build (etag 15666c63, asset /mr-11/assets/index-CxUVOTKD.js matches the deploy:mr build). Moving to Reviewing.

MR: https://gitlab.wikimedia.org/daanvr/upload-workbench/-/merge_requests/11
Preview: https://upload-workbench.toolforge.org/mr-11/

Daanvr moved this task from Reviewing to Done on the Tool-upload-workbench board.May 9 2026, 10:57 AM
Daanvr closed this task as Resolved.May 9 2026, 11:07 AM
Daanvr mentioned this in T425885: Upload history view: bug fixes + metadata audit (!31).May 10 2026, 6:05 PM
Daanvr mentioned this in T425839: Manual photo groups in table view (persistent, stacked-tables layout) (!20).May 11 2026, 2:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits