Category pill popover shows placeholder data; needs real Commons fetch + 'Open on Commons' link
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daanvr
	May 8 2026, 9:36 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Daanvr

Description

Bug

Click a category pill in a table cell → a preview popover appears with the category name, a generic description, an "Existing / Will be created" status, and an "Open on Commons" footer button.

Two problems:

All preview content is placeholder. The description sentence is hardcoded; no Commons API fetch. The "existing" status comes from the local KNOWN_CATEGORIES pool plus the live-bridged results, but no real category-page data (description, file count, parent cats) is rendered.
"Open on Commons" button has no onClick — dead button.

Where

src/table.jsx:2649-2671 — PillInfoPopover category branch. Dead button at line 2667.

Expected

Build the popover for real:

Fetch live category info from Commons (file count, lead description, parent cats); cache 5 min.
Wire "Open on Commons" to open https://commons.wikimedia.org/wiki/Category:<name> in a new tab.

Reported by

Daanvr, 2026-05-08, during dead-UI review.

Related Objects

Mentioned In: T425851: Merge Request live previeuw bug
T425828: Freeze leftmost columns (checkbox, status, photo, side-panel) when horizontally scrolling the table
Mentioned Here: T425827: Depicts pill popover shows placeholder data; needs real Wikidata fetch + 'Open on Wikidata' link
T425828: Freeze leftmost columns (checkbox, status, photo, side-panel) when horizontally scrolling the table

Event Timeline

Daanvr created this task.May 8 2026, 9:36 PM

Daanvr triaged this task as Medium priority.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2026, 9:36 PM

Daanvr moved this task from Backlog to To do on the Tool-upload-workbench board.May 9 2026, 7:00 AM

Daanvr claimed this task.May 9 2026, 7:52 AM

Daanvr moved this task from To do to Doing on the Tool-upload-workbench board.

@Daanvr — implementation done & pushed (MR: https://gitlab.wikimedia.org/daanvr/upload-workbench/-/merge_requests/10), but the MR preview URL is broken for all MRs, not just this one (sibling T425827 hit the same wall and is also in Needs input).

What works

CI green; build ran with VITE_BASE_PATH=/mr-10/ and rsynced dist/ to /data/project/upload-workbench/www/static/mr-10/. The asset is reachable: https://upload-workbench.toolforge.org/mr-10/assets/index-BcDhcQjV.js → 200, 352 KB.

What's broken

Toolforge's lighttpd 301-redirects /mr-10/index.html → /mr-10/index → /mr-10 → /mr-10/, then serves the root /index.html as a SPA fallback. So a user visiting https://upload-workbench.toolforge.org/mr-10/ sees the production build (assets resolving against /), not my MR's build. CLAUDE.md → Task workflow → step 5 explicitly says 'Do not push the task to Reviewing if its preview doesn't load' / 'assets resolve against /'.
All three open MR previews (/mr-9/, /mr-10/, and the not-yet-pushed !? for T425828) share the same etag: e505... as / — proof the preview is the root build.

Why this is happening

Toolforge's static-server config strips .html and falls back to root /index.html for any path that doesn't directly resolve to a file. The directory-as-URL convention (/mr-10/) doesn't auto-serve /mr-10/index.html because the .html-stripping rule kicks in first. /v0.4.0/ shows a directory listing instead — also evidence of the same routing.
Feature is only ~1 day old (commit 10031b9 on 2026-05-08). Likely never end-to-end tested with a real MR before now.

Options I see

Server-side: add a lighttpd rewrite rule that maps /mr-<n>/ → /mr-<n>/index.html *before* the SPA fallback. Needs Toolforge service config (out of scope for me).
Client-side workaround: change deploy:mr to rsync the build to /mr-<iid>.html (not a directory) so the URL is a file the lighttpd resolves directly. Slightly awkward but no infra change needed.
Inline asset: build with base: './' for MR previews so assets are referenced relatively. But the URL itself still serves root index.html, so this doesn't help.
Document the limitation and have reviewers test on the maintainer's local checkout for now.

I'm holding T425829 here pending your call. The MR diff itself is small and self-contained — code review by reading is fine if you want to skip the live preview for now.

Daanvr mentioned this in T425828: Freeze leftmost columns (checkbox, status, photo, side-panel) when horizontally scrolling the table.May 9 2026, 8:05 AM

Daanvr mentioned this in T425851: Merge Request live previeuw bug.May 9 2026, 8:32 AM

Preview infra fix !12 is merged & deployed; webservice restarted. Verified /mr-10/ now serves this MR's own build (etag 0771349b, asset /mr-10/assets/index-BcDhcQjV.js matches the deploy:mr build). Moving to Reviewing.

MR: https://gitlab.wikimedia.org/daanvr/upload-workbench/-/merge_requests/10
Preview: https://upload-workbench.toolforge.org/mr-10/

Daanvr moved this task from Reviewing to Done on the Tool-upload-workbench board.May 9 2026, 10:57 AM

Daanvr closed this task as Resolved.May 9 2026, 11:07 AM

Category pill popover shows placeholder data; needs real Commons fetch + 'Open on Commons' linkClosed, ResolvedPublicActions