Page MenuHomePhabricator

Hidden files UX: preview + stable toggle (!30)
Closed, ResolvedPublic

Description

Summary

The Hidden Files view has two problems:

  1. No useful information — hidden file rows show no preview thumbnail and no metadata, so the user can't easily identify what they hid.
  2. Toggle-target shift — clicking the "show hidden" button moves the now-visible hidden rows into the table; on the next click (to hide again), the rows leave, which shifts the button itself. The toggle target literally moves out from under the user's cursor.

Issues

Issue 1: Hidden files lack a useful preview

  • Each hidden file row should show a thumbnail (same size as the active view — Grid / List / Table).
  • Show the time-remaining-in-stash countdown ("expires in 23h 12m") — same source as the existing stash-section header. This is the most actionable piece of info: a hidden file about to expire is a hidden file about to disappear.
  • Show the basic metadata that's already in the stash record (filename, size, dimensions where known).

Issue 2: Hidden-toggle target shifts

The "Show hidden / Hide hidden" button must stay in a stable position regardless of how many rows the toggle reveals or hides.

Pick whichever of these preserves the existing visual rhythm best:

  • Move the button to a position the table can't displace (e.g. fixed in the toolbar / section header strip).
  • Render hidden files as a clearly-separated visual block (e.g. below regular files, with its own header), so revealing them grows the block downward and doesn't push the button.

Acceptance

  • Hidden file rows show a thumbnail + filename + stash-expiry countdown + basic size/dimensions.
  • Toggling Show / Hide hidden does not move the toggle button itself.
  • Hidden vs visible state is unambiguous (e.g. distinct background, "Hidden" chip on each hidden row).

Source

User feedback session, 2026-05-10.

Event Timeline

Daanvr updated the task description. (Show Details)
Daanvr moved this task from To do to Doing on the Tool-upload-workbench board.

some small changes. Um I would like it to be obvious for the hidden files if they are duplicates. uh in their sort of row. uh it should be obvious that there are duplicates. The expiration date uh or expression time is set in days but should be in hours. Never days, always hours. No. And there is a thymal preview. Uh I would like to be able to see the big image when clicking on the thumbnail.

Daanvr renamed this task from hidden files to Hidden files UX: preview + stable toggle (!30).May 11 2026, 2:13 PM

Iterated per feedback (2026-05-11):

  • Hidden rows now show a duplicate-state chip — "Already on Commons" / "Twin in stash" / "Already published" — with the same chip--warn styling as the visible Card view, plus a muted-warning left border on the row when any duplicate state applies. Reuses the existing findDuplicate / findStashDuplicate selectors so coverage matches the visible views.
  • Clicking the thumbnail now opens the lightbox (big image preview); clicking the row body still opens the detail panel — same split as the visible stash views. The thumbnail desaturation lifts on hover, and the cursor is zoom-in, so the affordance is unambiguous.
  • Stash expiry countdowns are always in hours, never days — both formatStashRemaining (hidden rows) and timeUntil (regular Card meta + DetailPanel "Expires") now read e.g. 'in 47h 12m' / 'in 23h' / 'in 17m'. Same hours-only convention the stash-section header already used.

Preview updated: https://upload-workbench.toolforge.org/mr-30/

Released as v0.15.0 (MR !30 merged into main).