@Lwilson-ctr Transferred your suggestions here. Anything missing or incorrectly described?

Change #1309228 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/PersonalDashboard@master] Further improvements to UI of Review Changes cards

https://gerrit.wikimedia.org/r/1309228

Test wiki created on Patch demo by DHardy-WMF using patch(es) linked to this task:
https://6941aa7e06.catalyst.wmcloud.org/w/

This looks good to me! Tested/verified every bullet point in this task.

In T426183#12108636, @Samwalton9-WMF wrote:

This looks good to me! Tested/verified every bullet point in this task.

Thanks, @Samwalton9-WMF! I just fixed a bug where clicking on the user info button would incorrectly grey out the review changes card, so it might be worth a quick re-check.

In T426183#12109457, @Samwalton9-WMF wrote:

Is this expected in the patch demo environment?

Interesting... I've never seen that error message before. Does the browser console show anything?

TypeError: triggerElement.closest is not a function
    getOpenContext util.js:111
    open App.vue:31
    togglePopover init.js:36
errorLogger.js:19:11

XHRPOST
https://6941aa7e06.catalyst.wmcloud.org/w/rest.php/checkuser/v0/userinfo?uselang=en
[HTTP/2 500  333ms]

The 500 response is

message 'Error: exception of type Error: Interface "Wikimedia\\MetricsPlatform\\EventSubmitter" not found'
exception { id: "15203803bc42e39f9c378df0", type: "Error", file: "/var/www/html/w/extensions/EventLogging/includes/MetricsPlatform/EventSubmitter.php", … }
httpCode 500
httpReason "Internal Server Error"

In T426183#12109518, @Samwalton9-WMF wrote:

TypeError: triggerElement.closest is not a function
    getOpenContext util.js:111
    open App.vue:31
    togglePopover init.js:36
errorLogger.js:19:11

XHRPOST
https://6941aa7e06.catalyst.wmcloud.org/w/rest.php/checkuser/v0/userinfo?uselang=en
[HTTP/2 500  333ms]

The 500 response is

message 'Error: exception of type Error: Interface "Wikimedia\\MetricsPlatform\\EventSubmitter" not found'
exception { id: "15203803bc42e39f9c378df0", type: "Error", file: "/var/www/html/w/extensions/EventLogging/includes/MetricsPlatform/EventSubmitter.php", … }
httpCode 500
httpReason "Internal Server Error"

Okay I was able to reproduce the error on my end. This is what I gathered so far:

• It occurs on all pages with the user info card, including Recent Changes and Watchlist.
• This is happening on other new instances of Patch Demo as well.
• Maybe something broke between EventLogging extension and Metrics Platform client?
• Or Patch Demo isn't properly installing/resolving the wikimedia/metrics-platform composer dependency?

In T426183, @jsn.sherman wrote:

not blocking: I think we need to do an a11y pass. each card now has 3 tab stops and the overlay link has no focus target or styling. Not blocking because we haven't done such a pass in a while, so it should probably be its own task.

While I agree on an a11y pass, what if a user intentionally wants to focus on the title, user info card, or username anchors?

Also I'm unable to reproduce the no focus target or styling issue. Both Review Changes and Active Discussions look identical on Firefox and Chrome:

	Review Changes (overlay is the anchor)	Active Discussions (card is the anchor)
Firefox
Chrome

that's ... weird. I was definitely not getting the focus rings in dark mode, even after a hard refresh. I switched out of dark mode, and they were visible in light mode. and now they are visible in dark mode too.

Change #1309228 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Further improvements to UI of Review Changes cards

https://gerrit.wikimedia.org/r/1309228

Interesting to see that this has resulted in an extra border on desktop, matching the one on mobile. Is that for the same underlying reason as for T432468? (i.e. should I broaden that ticket to both desktop and mobile?)

old	new

Test wiki on Patch demo by DHardy-WMF using patch(es) linked to this task was deleted:

https://6941aa7e06.catalyst.wmcloud.org/w/