Page MenuHomePhabricator
Create Task
Maniphest T426198

Event schemas - mediawiki user entity should be wiki aware
Closed, ResolvedPublic
Actions

Description

In Fix TypeError on saving userrights interwiki (1286880) I learned that user group changes can happen cross wikis. Stewards on metawiki can change rights for users on other wikis via Special:UserRights targeting an cross wiki user like 'User@otherwiki'.

When a user UserGroupsChange hook is called, it happens on the performer's wiki, e.g. metawiki, but the target user who's groups have changed are on the remote wiki.

Done is

More details in this Slack thread.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
mediawiki.user_change.dev0 - key by user.wiki_idOttomataoperations/mediawiki-configmaster+6 -1
BugFix: Emit page_change at version 1.6.0 to pick up user wiki_idOttomatamediawiki/extensions/EventBusmaster+1 -1
BugFix: Emit page_change at version 1.6.0 to pick up user wiki_idOttomatamediawiki/extensions/EventBuswmf/1.47.0-wmf.3+1 -1
EventBus UserEntitySerializer - make wiki awareOttomatamediawiki/extensions/EventBusmaster+802 -134
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Add wiki_id field to mediawiki user entity fragment schema 1.2.0repos/data-engineering/schemas-event-primary!50ottouser_wiki_awaremaster
Customize query in GitLab

Related Objects
Search...

Event Timeline

Ottomata created this task.May 13 2026, 1:30 PM
Ottomata added a subtask: T424767: EventBus - consider schema versions when serializing entities.

We will need T424767: EventBus - consider schema versions when serializing entities to do this nicely.

Ottomata mentioned this in T425735: interwiki imports and its effects on revision data.May 13 2026, 3:03 PM
CodeReviewBot added a project: Patch-For-Review.May 13 2026, 6:13 PM

otto opened https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-primary/-/merge_requests/50

Add wiki_id field to mediawiki user entity fragment schema 1.2.0

gerritbot added a comment.May 13 2026, 6:16 PM

Change #1286995 had a related patch set uploaded (by Ottomata; author: Ottomata):

[mediawiki/extensions/EventBus@master] EventBus UserEntitySerializer - make wiki aware

https://gerrit.wikimedia.org/r/1286995

Ottomata added subscribers: mszwarc, Dreamy_Jazz.May 14 2026, 11:08 AM

@Dreamy_Jazz , @mszwarc will be out for a few days, and I'd like to get this merged before next week's train. Are you available for review?

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventBus/+/1286995

Thank you!

gerritbot added a comment.May 18 2026, 4:30 PM

Change #1286995 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] EventBus UserEntitySerializer - make wiki aware

https://gerrit.wikimedia.org/r/1286995

CodeReviewBot added a comment.May 19 2026, 5:11 PM

otto merged https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-primary/-/merge_requests/50

Add wiki_id field to mediawiki user entity fragment schema 1.2.0

Maintenance_bot removed a project: Patch-For-Review.May 19 2026, 5:30 PM
gerritbot added a comment.May 19 2026, 7:10 PM

Change #1289407 had a related patch set uploaded (by Ottomata; author: Ottomata):

[mediawiki/extensions/EventBus@master] BugFix: Emit page_change at version 1.6.0 to pick up user wiki_id

https://gerrit.wikimedia.org/r/1289407

gerritbot added a project: Patch-For-Review.May 19 2026, 7:10 PM
gerritbot added a comment.May 19 2026, 7:18 PM

Change #1289408 had a related patch set uploaded (by Ottomata; author: Ottomata):

[mediawiki/extensions/EventBus@wmf/1.47.0-wmf.3] BugFix: Emit page_change at version 1.6.0 to pick up user wiki_id

https://gerrit.wikimedia.org/r/1289408

gerritbot added a comment.May 19 2026, 7:40 PM

Change #1289408 merged by jenkins-bot:

[mediawiki/extensions/EventBus@wmf/1.47.0-wmf.3] BugFix: Emit page_change at version 1.6.0 to pick up user wiki_id

https://gerrit.wikimedia.org/r/1289408

Stashbot added a comment.May 19 2026, 7:41 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-19T19:41:20Z] <otto@deploy1003> Started scap sync-world: Backport for [[gerrit:1289408|BugFix: Emit page_change at version 1.6.0 to pick up user wiki_id (T426198)]]

Stashbot added a comment.May 19 2026, 7:43 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-19T19:43:58Z] <otto@deploy1003> otto: Backport for [[gerrit:1289408|BugFix: Emit page_change at version 1.6.0 to pick up user wiki_id (T426198)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.May 19 2026, 7:57 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-19T19:57:35Z] <otto@deploy1003> Finished scap sync-world: Backport for [[gerrit:1289408|BugFix: Emit page_change at version 1.6.0 to pick up user wiki_id (T426198)]] (duration: 16m 15s)

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19); removed: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).May 19 2026, 8:00 PM
gerritbot added a comment.May 20 2026, 8:55 AM

Change #1289407 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] BugFix: Emit page_change at version 1.6.0 to pick up user wiki_id

https://gerrit.wikimedia.org/r/1289407

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.4; 2026-05-26); removed: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 20 2026, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 20 2026, 9:31 AM
gerritbot added a comment.Jun 1 2026, 3:18 PM

Change #1295950 had a related patch set uploaded (by Ottomata; author: Ottomata):

[operations/mediawiki-config@master] mediawiki.user_change.dev0 - key by user.wiki_id

https://gerrit.wikimedia.org/r/1295950

gerritbot added a project: Patch-For-Review.Jun 1 2026, 3:18 PM
Ottomata updated the task description. (Show Details)Jun 1 2026, 3:19 PM
Ottomata moved this task from Next Up to Ready to Deploy on the Data-Engineering (Q4 FS25/26 April 1st - June 30st) board.Jun 1 2026, 3:22 PM
gerritbot added a comment.Jun 1 2026, 6:17 PM

Change #1295950 merged by jenkins-bot:

[operations/mediawiki-config@master] mediawiki.user_change.dev0 - key by user.wiki_id

https://gerrit.wikimedia.org/r/1295950

Stashbot added a comment.Jun 1 2026, 6:17 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-01T18:17:38Z] <otto@deploy1003> Started scap sync-world: Backport for [[gerrit:1295950|mediawiki.user_change.dev0 - key by user.wiki_id (T426198)]]

Stashbot added a comment.Jun 1 2026, 6:19 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-01T18:19:28Z] <otto@deploy1003> otto: Backport for [[gerrit:1295950|mediawiki.user_change.dev0 - key by user.wiki_id (T426198)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 1 2026, 6:24 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-01T18:24:20Z] <otto@deploy1003> Finished scap sync-world: Backport for [[gerrit:1295950|mediawiki.user_change.dev0 - key by user.wiki_id (T426198)]] (duration: 06m 42s)

Ottomata updated the task description. (Show Details)Jun 1 2026, 6:24 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 1 2026, 6:31 PM
Ottomata moved this task from Ready to Deploy to Done on the Data-Engineering (Q4 FS25/26 April 1st - June 30st) board.Mon, Jun 22, 3:02 PM
Ahoelzl closed this task as Resolved.Tue, Jun 30, 4:26 PM
Ahoelzl closed subtask T424767: EventBus - consider schema versions when serializing entities as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits