Page MenuHomePhabricator
Create Task
Maniphest T426215

Add fallback for “Only resize when resizeUrl actually exists” bug
Closed, DuplicatePublic2 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Share highlight card not rendering

errorLogger.js:19 TypeError: parsedUrl.resizeUrl is not a function
    at getImageSrc (ShareQuoteDialog.vue:104:22)
    at tV.eval [as fn] (ShareQuoteDialog.vue:117:13)
    at eR (vue.js:5:8449)
    at get value (vue.js:5:19431)
    at ek.l [as fn] (vue.js:5:55236)
    at ek.run (vue.js:5:6967)
    at k (vue.js:5:55721)
    at vue.js:5:56056
    at rX (vue.js:5:56165)
    at vue.js:9:14814

What should have happened instead?:

The share highlight article shoulder render for all articles.
Like here: https://en.wikipedia.org/wiki/Earth?mpo=share-highlight:treatment

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Handle share-highlight images w/o resizeUrlJdlrobsonmediawiki/extensions/ReaderExperimentswmf/1.47.0-wmf.2+119 -2
Handle share-highlight images w/o resizeUrlKimberly Sarabiamediawiki/extensions/ReaderExperimentsmaster+119 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT416432 [Epic] Share Card experiment
 ResolvedKSarabia-WMFT424591 [Share Highlights] Bug Bash
 DuplicateBUG REPORTNoneT426215 Add fallback for “Only resize when resizeUrl actually exists” bug

Event Timeline

KSarabia-WMF created this task.May 13 2026, 3:17 PM
gerritbot added a comment.May 13 2026, 3:26 PM

Change #1286964 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/ReaderExperiments@master] Handle share-highlight images w/o resizeUrl

https://gerrit.wikimedia.org/r/1286964

gerritbot added a project: Patch-For-Review.May 13 2026, 3:26 PM
HSwan-WMF triaged this task as High priority.May 13 2026, 4:20 PM
HSwan-WMF moved this task from Sprint 3 (Apr 29 - May 12) Q4 25/26 to Sprint 4 (May 13 - 26) Q4 25/26 on the Reader Growth Team board.
HSwan-WMF edited projects, added: Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26); removed: Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26).
Jdlrobson-WMF subscribed.EditedMay 13 2026, 4:27 PM

It appears to impact share on articles with images where the original size is under a certain threshold.

There seems to be a bug in mw.util.resizeUrl
if you pass https://upload.wikimedia.org/wikipedia/commons/f/f3/Marc_autograph.png in it cannot resize the image because the original size of https://en.wikipedia.org/wiki/file:Marc_autograph.png is 267px I think in this case you want to use the image directly.

I can replicate on https://it.wikipedia.org/wiki/La_gabbianella_e_il_gatto?mpo=share-highlight:treatment#

egardner moved this task from Committed to Doing on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.May 13 2026, 5:05 PM
SherryYang-WMF set the point value for this task to 2.May 13 2026, 5:07 PM
gerritbot added a comment.May 13 2026, 6:29 PM

Change #1287000 had a related patch set uploaded (by Jdlrobson; author: Kimberly Sarabia):

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] Handle share-highlight images w/o resizeUrl

https://gerrit.wikimedia.org/r/1287000

gerritbot added a comment.May 13 2026, 7:01 PM

Change #1286964 merged by Eric Gardner:

[mediawiki/extensions/ReaderExperiments@master] Handle share-highlight images w/o resizeUrl

https://gerrit.wikimedia.org/r/1286964

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 13 2026, 8:00 PM
gerritbot added a comment.May 13 2026, 8:34 PM

Change #1287000 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] Handle share-highlight images w/o resizeUrl

https://gerrit.wikimedia.org/r/1287000

Stashbot added a comment.May 13 2026, 8:35 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-13T20:35:26Z] <jdlrobson@deploy1003> Started scap sync-world: Backport for [[gerrit:1287000|Handle share-highlight images w/o resizeUrl (T426215)]]

Stashbot added a comment.May 13 2026, 8:37 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-13T20:37:23Z] <jdlrobson@deploy1003> jdlrobson: Backport for [[gerrit:1287000|Handle share-highlight images w/o resizeUrl (T426215)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.May 13 2026, 8:42 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-13T20:42:58Z] <jdlrobson@deploy1003> Finished scap sync-world: Backport for [[gerrit:1287000|Handle share-highlight images w/o resizeUrl (T426215)]] (duration: 07m 32s)

Jdlrobson-WMF moved this task from Doing to QA on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.May 13 2026, 8:43 PM

It's now deployed and fixed on Italian (https://it.wikipedia.org/wiki/La_gabbianella_e_il_gatto?mpo=share-highlight:treatment#)
Will be fixed everywhere (including english wikipedia) tomorrow.

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12); removed: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 13 2026, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 13 2026, 9:31 PM
• mfossati closed this task as a duplicate of T425149: ShareHighlight - when image triggers "parsedUrl.resizeUrl is not a function", "Share quote" silently fails.May 14 2026, 9:36 AM
• mfossati mentioned this in T425149: ShareHighlight - when image triggers "parsedUrl.resizeUrl is not a function", "Share quote" silently fails.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits