Maniphest T426234

Optimize ve.dm.Document#findText
Open, Needs TriagePublic
Actions

Assigned To

Authored By

	dchan
	Wed, May 13, 5:33 PM

Tags

Referenced Files

None

Subscribers

Description

At present, ve.dm.Document#findText spends a lot of time grinding through linear data. Here are some basic profiling results with 100 regexp TextMatchEditChecks running:

2892 ve.dm.Document#findText:
  2401 ve.dm.LinearData#forEachRunOfContent
    ...
      845 ve.dm.LinearData#getCharacterData
      715 ve.dm.LinearData#isElementData
      575 ve.dm.TextFinder#find
        213 ve.dm.RegExpTextFinder.findRanges

As the profile shows, 7x longer is spent grinding linear data than actually testing regular expressions.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (2db0070d9)	mediawiki/extensions/VisualEditor	master	+1 -1
	Optimize ve.dm.Document#findText	VisualEditor/VisualEditor	master	+184 -35

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T421754 [Epic] Improve the performance of Edit Suggestions
		Open		dchan	T426234 Optimize ve.dm.Document#findText

Event Timeline

dchan created this task.Wed, May 13, 5:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, May 13, 5:33 PM

dchan added a parent task: T421754: [Epic] Improve the performance of Edit Suggestions.Wed, May 13, 5:34 PM

Maintenance_bot added a project: VisualEditor.Wed, May 13, 6:29 PM

Change #1287413 had a related patch set uploaded (by Divec; author: Divec):

[VisualEditor/VisualEditor@master] Optimize ve.dm.Document#findText

https://gerrit.wikimedia.org/r/1287413

gerritbot added a project: Patch-For-Review.Thu, May 14, 1:01 PM

dchan added a project: Editing-team (Editing-Q4-11May-22May-2026).Thu, May 14, 1:20 PM

dchan moved this task from Decision to be made to Dev Doing on the Editing-team (Editing-Q4-11May-22May-2026) board.

dchan moved this task from Dev Doing to Code review on the Editing-team (Editing-Q4-11May-22May-2026) board.

Change #1287413 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Optimize ve.dm.Document#findText

https://gerrit.wikimedia.org/r/1287413

Maintenance_bot removed a project: Patch-For-Review.Wed, May 20, 12:30 AM

Change #1289455 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2db0070d9)

https://gerrit.wikimedia.org/r/1289455

gerritbot added a project: Patch-For-Review.Wed, May 20, 1:26 AM

Change #1289455 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2db0070d9)

https://gerrit.wikimedia.org/r/1289455

Maintenance_bot removed a project: Patch-For-Review.Wed, May 20, 5:32 PM