Page MenuHomePhabricator
Create Task
Maniphest T426237

SuggestionMode: Exiting out of ReferenceCheck shows the virtual keyboard
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

When I exit out of 'Add a citation' (not dismiss, just exit), it opens up the keyboard, which I didn't previously have open. This doesn't happen when I exit out of other checks.

See example

Requirements

  • Don't show the keyboard after closing an edit check

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
EditCheck: Deactivate surface after closing EC dialog on mobilemediawiki/extensions/VisualEditormaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

medelius created this task.May 13 2026, 5:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2026, 5:48 PM
ppelberg triaged this task as High priority.May 13 2026, 5:52 PM
ppelberg added a parent task: T425595: [EPIC] Resolve outstanding UX issues/improvements post-experiment start.
ppelberg moved this task from Decision to be made to Ready for Dev on the Editing-team (Editing-Q4-11May-22May-2026) board.
ppelberg updated the task description. (Show Details)May 14 2026, 4:29 AM
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)
ppelberg mentioned this in T425595: [EPIC] Resolve outstanding UX issues/improvements post-experiment start.May 14 2026, 4:55 AM
medelius set the point value for this task to 3.Thu, May 14, 3:35 PM
gerritbot added a comment.Fri, May 15, 3:59 PM

Change #1287911 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] EditCheck: Deactivate surface after closing EC dialog on mobile

https://gerrit.wikimedia.org/r/1287911

gerritbot added a project: Patch-For-Review.Fri, May 15, 3:59 PM
Esanders renamed this task from SuggestionMode: Exiting out of ReferenceCheck does not return user to previous state to SuggestionMode: Exiting out of ReferenceCheck shows the virtual keyboard.Fri, May 15, 4:01 PM
Esanders updated the task description. (Show Details)
PatchDemoBot added a comment.Fri, May 15, 4:02 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://fa17f2e7a9.catalyst.wmcloud.org/wiki/Regent's Park?veaction=edit&ecenable=experimental,suggestions

Esanders claimed this task.Fri, May 15, 4:03 PM
Esanders moved this task from Ready for Dev to Code review on the Editing-team (Editing-Q4-11May-22May-2026) board.
gerritbot added a comment.Mon, May 18, 5:45 PM

Change #1287911 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: Deactivate surface after closing EC dialog on mobile

https://gerrit.wikimedia.org/r/1287911

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).Mon, May 18, 6:01 PM
Maintenance_bot removed a project: Patch-For-Review.Mon, May 18, 6:32 PM
DLynch moved this task from Code review to QA on the Editing-team (Editing-Q4-11May-22May-2026) board.Mon, May 18, 10:31 PM
DLynch added a project: Editing QA.
EAkinloose closed this task as Resolved.Mon, Jun 1, 7:02 PM
EAkinloose edited projects, added: Verified; removed: Editing QA.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits