Page MenuHomePhabricator
Create Task
Maniphest T426247

Share Highlight: Ensure dialog header is visible on small devices
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To
egardner
Authored By
egardner
Wed, May 13, 6:59 PM
Tags
Referenced Files
F83445803: Screenshot_20260522-071344_Samsung Internet.jpg
Fri, May 22, 2:44 PM
F83443575: IMG_8394.PNG
Fri, May 22, 2:44 PM
F81424183: Screenshot 2026-05-14 at 10.05.59 AM.png
Thu, May 14, 2:10 PM
F81424103: Screenshot 2026-05-14 at 10.04.16 AM.png
Thu, May 14, 2:10 PM
F81424085: Screenshot 2026-05-14 at 10.02.43 AM.png
Thu, May 14, 2:10 PM
F81243397: Simulator Screenshot - iPhone 16 - 2026-05-13 at 11.51.54.png
Wed, May 13, 6:59 PM
Subscribers
Aklapper
egardner
Etonkovidova
JScherer-WMF
mfossati
SherryYang-WMF

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The dialog header is clipped:

Simulator Screenshot - iPhone 16 - 2026-05-13 at 11.51.54.png (2×1 px, 1 MB)

What should have happened instead?:
The generated graphic (or the text inside of it) should be scaled down so that it fits adequately within the viewport, without changing the downloadable pixel-size of the graphic.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix dialog breaking out of viewportmediawiki/extensions/ReaderExperimentsmaster+17 -33
Scale share-highlight card to fit small viewportsmediawiki/extensions/ReaderExperimentswmf/1.47.0-wmf.2+33 -8
Scale share-highlight card to fit small viewportsmediawiki/extensions/ReaderExperimentsmaster+33 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

egardner created this task.Wed, May 13, 6:59 PM
egardner triaged this task as High priority.
egardner claimed this task.Wed, May 13, 7:06 PM
egardner moved this task from Committed to Doing on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.
gerritbot added a comment.Wed, May 13, 8:07 PM

Change #1287014 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/ReaderExperiments@master] Scale share-highlight card to fit small viewports

https://gerrit.wikimedia.org/r/1287014

gerritbot added a project: Patch-For-Review.Wed, May 13, 8:07 PM
egardner moved this task from Doing to Code Review on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.Wed, May 13, 8:07 PM
gerritbot added a comment.Wed, May 13, 9:24 PM

Change #1287014 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Scale share-highlight card to fit small viewports

https://gerrit.wikimedia.org/r/1287014

Maintenance_bot removed a project: Patch-For-Review.Wed, May 13, 9:31 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).Wed, May 13, 10:00 PM
egardner moved this task from Code Review to QA on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.Wed, May 13, 10:32 PM
lwatson mentioned this in T425710: Make cards fixed width.Wed, May 13, 11:29 PM
gerritbot added a comment.Thu, May 14, 9:16 AM

Change #1287363 had a related patch set uploaded (by Marco Fossati; author: Eric Gardner):

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] Scale share-highlight card to fit small viewports

https://gerrit.wikimedia.org/r/1287363

gerritbot added a project: Patch-For-Review.Thu, May 14, 9:16 AM
gerritbot added a comment.Thu, May 14, 1:53 PM

Change #1287363 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] Scale share-highlight card to fit small viewports

https://gerrit.wikimedia.org/r/1287363

Stashbot added a comment.Thu, May 14, 1:53 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-14T13:53:46Z] <mfossati@deploy1003> Started scap sync-world: Backport for [[gerrit:1287363|Scale share-highlight card to fit small viewports (T426247)]]

Stashbot added a comment.Thu, May 14, 1:55 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-14T13:55:35Z] <mfossati@deploy1003> mfossati: Backport for [[gerrit:1287363|Scale share-highlight card to fit small viewports (T426247)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

ReleaseTaggerBot edited projects, added MW-1.47-notes (1.47.0-wmf.2; 2026-05-12); removed MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).Thu, May 14, 2:00 PM
Stashbot added a comment.Thu, May 14, 2:00 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-14T14:00:56Z] <mfossati@deploy1003> Finished scap sync-world: Backport for [[gerrit:1287363|Scale share-highlight card to fit small viewports (T426247)]] (duration: 07m 09s)

Etonkovidova subscribed.Thu, May 14, 2:10 PM

Checked on enwiki beta - https://en.wikipedia.beta.wmcloud.org/wiki/Antarctica?mpo=share-highlight%3Atreatment

Screenshot 2026-05-14 at 10.02.43 AM.png (639×292 px, 108 KB)
Screenshot 2026-05-14 at 10.04.16 AM.png (750×372 px, 161 KB)
Screenshot 2026-05-14 at 10.05.59 AM.png (1×680 px, 413 KB)
Maintenance_bot removed a project: Patch-For-Review.Thu, May 14, 2:31 PM
Etonkovidova moved this task from QA to Signoff on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.Thu, May 14, 2:58 PM
gerritbot added a comment.Fri, May 15, 12:51 PM

Change #1287865 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Fix dialog breaking out of viewport

https://gerrit.wikimedia.org/r/1287865

gerritbot added a project: Patch-For-Review.Fri, May 15, 12:51 PM
matthiasmullie moved this task from Signoff to Code Review on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.Fri, May 15, 12:52 PM
SherryYang-WMF set the point value for this task to 3.Tue, May 19, 4:25 PM
gerritbot added a comment.Tue, May 19, 5:20 PM

Change #1287865 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Fix dialog breaking out of viewport

https://gerrit.wikimedia.org/r/1287865

Maintenance_bot removed a project: Patch-For-Review.Tue, May 19, 5:30 PM
lwatson moved this task from Code Review to QA on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.Tue, May 19, 5:38 PM
ReleaseTaggerBot edited projects, added MW-1.47-notes (1.47.0-wmf.4; 2026-05-26); removed MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).Tue, May 19, 6:00 PM
Etonkovidova moved this task from QA to Signoff on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.EditedFri, May 22, 2:44 PM

Re-checked beta cluster and itwiki wmf.3 (the screenshots below are from itwiki wmf.3from real devices)

before the fixafter the fix - iPhone 414x896after the fix - Samsung Galaxy S8 360x740
Simulator Screenshot - iPhone 16 - 2026-05-13 at 11.51.54.png (2×1 px, 1 MB)
The share quote dialog is displayed fully
IMG_8394.PNG (640×296 px, 446 KB)
The share quote dialog is displayed fully
Screenshot_20260522-071344_Samsung Internet.jpg (2×1 px, 616 KB)

Note:
Small screen size refers to the screens up to 360px. Before the fix the issue was observed on the standard size screens - 414px. That's why iPhone screenshot (414px) is included.

mfossati closed this task as Resolved.Tue, May 26, 10:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits