Page MenuHomePhabricator
Create Task
Maniphest T426260

Split orchestrator's "invariants" object into actually-invariant OrchestratorConfig vs. call-specific RequestContext
Open, In Progress, MediumPublic
Actions

Description

Noticed when thinking about T418016: Banish circular refrences from Invariants. The object is doing double-duty, which is confusing and unnecessary.

Related Objects

Event Timeline

Jdforrester-WMF created this task.Wed, May 13, 8:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, May 13, 8:44 PM
Jdforrester-WMF triaged this task as Medium priority.Wed, May 13, 8:48 PM
Jdforrester-WMF added a project: Abstract Wikipedia team.
Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.
cmassaro subscribed.Wed, Jun 3, 5:26 PM

Good idea. We've already added wfConfig as the wrapper for both Invariants (including orchestrator config) and things like scope. A further reworking of this stuff absolutely makes sense.

Jdforrester-WMF changed the task status from Open to In Progress.Wed, Jun 3, 7:45 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (26Q4 (Apr–Jun)), Essential-Work; removed Abstract Wikipedia team.

Cool, will give this a whirl.

DSantamaria moved this task from Incoming to In Engineering on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.Wed, Jun 3, 8:41 PM
Jdforrester-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.Wed, Jun 3, 8:42 PM
CodeReviewBot added a project: Patch-For-Review.Wed, Jun 3, 8:46 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/700

Invariants: Split into OrchestratorConfig and RequestContext

CodeReviewBot added a comment.Wed, Jun 3, 11:31 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/700

Invariants: Split into OrchestratorConfig and RequestContext

Maintenance_bot removed a project: Patch-For-Review.Thu, Jun 4, 12:30 AM
Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.Thu, Jun 4, 2:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits