Page MenuHomePhabricator

ipRevealUtils.setRevealedStatus guard is always true
Closed, ResolvedPublicBUG REPORT

Description

From modules/ext.checkUser.tempAccounts/ipRevealUtils.js:

function getRevealedStatusKey( user ) {
	return 'mw-checkuser-temp-' + user;
}
function getRevealedStatus( user ) {
	return mw.storage.get( getRevealedStatusKey( user ) );
}
function setRevealedStatus( user ) {
	if ( !getRevealedStatus( getRevealedStatusKey( user ) ) ) {
		mw.storage.set(/* ... */);
	}
}

Obviously, the getRevealedStatus() call in setRevealedStatus will always be falsy, since the key to be checked would look something like mw-checkuser-temp-mw-checkuser-temp-~2026-12345-67. I'm not sure if this corresponds to any actual bugs.

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
NguoiDungKhongDinhDanh renamed this task from ipRevealUtils.setRevealedStatus check is always false to ipRevealUtils.setRevealedStatus guard is always true.May 14 2026, 2:11 AM
NguoiDungKhongDinhDanh updated the task description. (Show Details)

Change #1287048 had a related patch set uploaded (by NguoiDungKhongDinhDanh; author: NguoiDungKhongDinhDanh):

[mediawiki/extensions/CheckUser@master] Do not add key prefix twice

https://gerrit.wikimedia.org/r/1287048

Change #1287048 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Do not add key prefix twice

https://gerrit.wikimedia.org/r/1287048